Fix stuck call to Dial when calling Stop on the Initiator#654
Merged
ackleymi merged 1 commit intoAug 9, 2024
Merged
Conversation
Contributor
Author
|
I have tested this locally using a program sending a SIGTERM and calling |
This commit fixes an issue when calling Start() and then Stop() on the initiator while the connection is likely to fail and timeout. Calling initiator.Stop() will block since Dial will attempt to connect until it times out and returns on the 'waitForReconnectInterval' call. We mitigate this problem by using a proxy.ContextDialer and allowing to pass a context with cancellation method to the dialer.DialContext method on 'handleConnection'. We need to start a routine listening for the stopChan in order to call cancel() explicitly and thus exit the DialContext method. Note: there are scenarios where cancel() will be called twice, this choice was made in order to avoid a larger refactor of the reconnect logic, but since the call to cancel() is idempotent, this doesn't lead to any adverse effect. fixes quickfixgo#653 Signed-off-by: Alexandre Beslic <ab21c8b9f7@abronan.com>
abronan
force-pushed
the
mitigate-stuck-dial-on-initiator-stop
branch
from
5121af8 to
3939268
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes an issue when calling Start() and then Stop() on the initiator while the connection is likely to fail and timeout. Sending a SIGTERM and calling Stop() will block since Dial will attempt to connect until it times out and returns on the
waitForReconnectIntervalcall.We mitigate this problem by using a
proxy.ContextDialerand allowing to pass a context with cancellation method to thedialer.DialContextmethod onhandleConnection.We need to start a routine listening for the
stopChanin order to call cancel() explicitly and thus exit the DialContext method.Note: there are scenarios where
cancel()will be called twice, this choice was made in order to avoid a larger refactor of the reconnect logic, but since the call tocancel()is idempotent, this doesn't lead to any adverse effect.fixes #653