Support updates in the QLever UI #126
Conversation
requires that qlever also accepts the access token from the authorization header file
hannahbast
left a comment
hannahbast
left a comment
There was a problem hiding this comment.
1-1 with Julian, looks great and works, thanks a lot!
It would be great to show a meaningful message (like: "Update successful") when the update was successful (no need to display the JSON for this PR).
hannahbast
left a comment
hannahbast
left a comment
There was a problem hiding this comment.
1-1 with Julian, this looks great and works. A few suggestions for improvement:
- Remove the extra space before the "Automatically add names ..."
- Add button for "Clear delta triples" and "Clear cache complete"
- Add some more information to the "Update successful" message
NOTE: There already is a field for the access token (called API token) in the backend config as well as buttons for clear cache etc.
The whole warmup functionality is broken quite much (see #130). Fixing that that is out of scope, so I won't add a corresponding |
There was a problem hiding this comment.
Thorough 1-1 with Julian, this is great and works fine now. A few more glitches:
- Functionality of the new buttons: when successful after the red x, the spinning wheel icon disappears completely
- When buttons are displayed the whole column moves to the left; more padding
- Number of inserted triples is 0 although it isn't (maybe same for delete triples)
- Show backend command buttons (Clear Delta Triples, Clear Cache (Complete) iff Access Token is not empty. Fixed that the buttons would not be shown if the field was not empty on load. - Backend command button icons are set correctly when transitioning between states (running, failed, succeeded). The buttons now also return to the green color after a successful execution. - Columns of Basic settings table in Backend Information changed widths when the backend command buttons where shown/hidden. Fixed by having them beneath each other. - Backend command buttons have some padding. - If the operation type was not detected this could also cause indefinite operation execution (although this seems to not be the only cause). Display an error in this case and prompt to report it.
|
6b0b2e3 contains an extensive description of the changes and fixes. |
hannahbast
left a comment
hannahbast
left a comment
There was a problem hiding this comment.
1-1 with Julian, last round, this looks great now and works, thanks a lot!
PR #126 introduced an automatic detection whether the operation is `query` or `update`. This was done via regexes and not correct in all cases. This is now fixed by using `qlue-ls` for parsing (and defaulting to type `query` when the parser could not determine the type). Resolves #137. Resolves #138. Resolves ad-freiburg/qlever#1838. Resolves #140.
2 participants
With this change, the QLever UI supports updates. Under "Backend Information", an access token can be entered, in which case, two new buttons "Clear Delta Triples" and "Clear Cache (Complete)" appear. When an update has been entered and executed and the access token is correct and the update worked, a message "Update successful (insert triples: ..., delete triples: ...)" is displayed. Fixes #122