Skip to content

Conversation

@cirocosta
Copy link

As having release stuff in the souce code sucks and we want to be able to have access to those files when running npm install, e.g, by having a postinstall script setten up we can achieve that.


Just like jquery (jquery/jquery#1620), we could drop bower support and go along with npm itself

@cirocosta
Copy link
Author

Tested with npm install git+ssh://git@github.com:cirocosta/PathFinding.js.git#patch-1, it works great. Just not seem so good to have to download uglify and browserify (they are not anymore just dev dependencies)

@qiao
Copy link
Owner

qiao commented Aug 4, 2014

One problem with this approach is that Windows users won't be able to use this library, since they don't have make preinstalled on their machines.

@cirocosta
Copy link
Author

yeah, that's true. What do you think about using gulp for the build process instead of relying on make?

@imor
Copy link
Collaborator

imor commented Nov 18, 2014

As of commit 9d629d2 the build system uses gulp which is platform independent. Make is no longer a requirement. @cirocosta Quoting a comment from timmywil on the jquery issue:

Just to be clear, this is for our internal dependency management. We will continue to support installing jquery with bower.

Did you also mean to use npm for creating browser builds and still support bower? Or something else? Anyway after 9d629d2 it is possible to generate the builds with gulp scripts. See README for more details.

Can I close this PR?

@cirocosta
Copy link
Author

Yep, after that commit i think it is pretty ok 😃 👍

@imor imor closed this Nov 18, 2014
@cirocosta cirocosta deleted the patch-1 branch November 18, 2014 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants