Make tensor comparison return type match upstream PyTorch #833
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asuhan
force-pushed
the
asuhan/bool_comparison_type
branch
from
85da967 to
f838d73
Compare
dlibenzi
requested changes
Jul 18, 2019
asuhan
force-pushed
the
asuhan/bool_comparison_type
branch
2 times, most recently
from
508ea51 to
7ddd520
Compare
dlibenzi
approved these changes
Jul 19, 2019
asuhan
force-pushed
the
asuhan/bool_comparison_type
branch
from
7ddd520 to
7218e06
Compare
Contributor
|
PT PR has been merged, @asuhan would you mind rebasing this PR to see if it passes? Thanks! |
asuhan
force-pushed
the
asuhan/bool_comparison_type
branch
from
7218e06 to
74c98bb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will address #815 once pytorch/pytorch#21113 lands. Don't land until then, this isn't compatible with the current PyTorch master.