Simplify training progress logging to avoid reliance on global batch_size.#3749
Simplify training progress logging to avoid reliance on global batch_size.#3749UtkarshSingh31 wants to merge 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3749
Note: Links to docs will display an error until the docs builds have been completed. ❗ 1 Active SEVsThere are 1 currently active SEVs. If your PR is affected, please view them below: ✅ No FailuresAs of commit d68e031 with merge base e8b4de5 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
Hi @UtkarshSingh31! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
svekars
added
the
core
|
CI appears to be failing during 'apt-get update' due to a missing Yarn GPG key, before any tutorial execution. This looks unrelated to the PR changes. Happy to re-run once CI is fixed. |
2 participants
Description
This PR simplifies the computation of the training progress counter (
current) in the optimization tutorial.The existing example computes
currentusing a globalbatch_sizevariable. While this works in the current context, it introduces an unnecessary dependency on global state and can make the example harder to reason about or reuse if modified.Computing
currentasbatch * len(X)directly reflects the number of samples processed so far, avoids reliance on external assumptions, and naturally handles variable batch sizes.This change affects logging only and does not modify training behavior or results.
Checklist
Happy to adjust wording or implementation if there is a preferred tutorial style.
cc @albanD @jbschlosser