docs: clarify NumPy to tensor conversion semantics#3733
Open
zaydabash wants to merge 5 commits intopytorch:mainfrom
Open
docs: clarify NumPy to tensor conversion semantics#3733zaydabash wants to merge 5 commits intopytorch:mainfrom
zaydabash wants to merge 5 commits intopytorch:mainfrom
Conversation
svekars
added
the
core
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This tutorial uses a NumPy array to create a tensor, which can be confusing because some conversion APIs share memory while others copy. This PR adds a short note clarifying that torch.from_numpy shares memory when possible, while torch.tensor makes a copy, and that torch.as_tensor avoids a copy when possible.
cc @albanD @jbschlosser