Fix backpropagation order in optimization tutorial#3676
Open
patrocinio wants to merge 2 commits intopytorch:mainfrom
Open
Fix backpropagation order in optimization tutorial#3676patrocinio wants to merge 2 commits intopytorch:mainfrom
patrocinio wants to merge 2 commits intopytorch:mainfrom
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/tutorials/3676
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit f4e16a7 with merge base 7f8b6dc ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Reorder optimizer.zero_grad(), loss.backward(), and optimizer.step() to match the recommended best practice documented in the tutorial. Fixes pytorch#3507
patrocinio
force-pushed
the
3507_Optmizing_Model_Parameters
branch
from
7e70fc2 to
ed984c1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reorder optimizer.zero_grad(), loss.backward(), and optimizer.step() to match the recommended best practice documented in the tutorial.
Fixes #3507
Description
Checklist