Skip to content

[cuDNN][cuDNN V8 API] Fix incorrect use of emplace in the benchmark cache #97838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
eqy wants to merge 1 commit into from
Closed

[cuDNN][cuDNN V8 API] Fix incorrect use of emplace in the benchmark cache #97838

eqy wants to merge 1 commit into from

Conversation

@eqy
Copy link
Collaborator

@eqy eqy commented Mar 28, 2023 •
edited by pytorch-bot bot
Loading

emplace does not overwrite the existing mapped value in a map if it already exists, which can lead to repeated execution of a plan that e.g., tries to allocate an OOM-inducing workspace size and retriggers either a heuristic run (or worse, a benchmark run).

CC @ptrblck @ngimel @Fuzzkatt @syed-ahmed

cc @csarofeen @ptrblck @xwang233

@eqy eqy added module: cudnn Related to torch.backends.cudnn, and CuDNN support open source topic: not user facing topic category labels Mar 28, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 28, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/97838

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

❌ 1 Failures

As of commit 7e8b4ee:

BROKEN TRUNK - The following jobs failed but were present on the merge base 08f125b:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@eqy eqy requested a review from ngimel March 29, 2023 00:00
@eqy eqy added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 29, 2023
@eqy
Copy link
Collaborator Author

eqy commented Mar 29, 2023

@pytorchmergebot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Mar 29, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@eqy eqy mentioned this pull request Apr 6, 2023
Closed
eqy added a commit that referenced this pull request Apr 6, 2023
@eqy
[cuDNN][cuDNN V8 API] Fix incorrect use of emplace in the benchmark c…
cb186d2 
…ache #97838
This was referenced Apr 6, 2023
Merged
Closed
atalman pushed a commit that referenced this pull request Apr 6, 2023
@eqy
[cuDNN][cuDNN V8 API] Fix incorrect use of emplace in the benchmark c…
f08d20a 
…ache (#97838) (#98528)

* [cuDNN][cuDNN V8 API] Fix incorrect use of emplace in the benchmark cache #97838

* Update Conv_v8.cpp
@atalman atalman added this to the 2.0.1 milestone May 3, 2023
@cechallenge cechallenge mentioned this pull request Oct 17, 2023
Closed
@github-actions github-actions bot deleted the eqy-patch-13 branch September 28, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ngimel ngimel ngimel approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: cudnn Related to torch.backends.cudnn, and CuDNN support open source topic: not user facing topic category

Projects

None yet

Milestone

2.0.1

Development

Successfully merging this pull request may close these issues.

5 participants

@eqy @pytorchmergebot @ngimel @atalman