-
Notifications
You must be signed in to change notification settings - Fork 26.3k
[WIP] Add batched version of potrf #9623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@ethanluoyc thanks for the contribution! I can review this after you're done with it; feel free to ping with any questions; |
|
@zou3519 one very general question though. |
|
I implemented batch gesv a while ago as a part of For API cleanliness, it would be nice for the batched operations and unbatched operations to be a part of the same function, like |
|
What is the status of this PR? |
|
@zou3519 I am having some issue with passing the tests. What I currently have is a simple wrapper around dpotrf_. I can't find out why this is giving me the wrong result. Would you be able to take a breif look and see if there are obvious mistakes? |
|
Hi. My apologies for not checking before going this far. |
|
This can be closed since batched cholesky is merged into master. |
This PR intends to add batched version of potrf (see #7500).
On CPU, this is implemented as a for loop which then calls MKL's potrf. On the GPU, MAGMA has
a batched version of potrf so we use that.
Currently there is still some cleanup to do. I am putting this up here so that nobody else will duplicate the effort.