[ROCM] Restrict pytorch rocm to only use triton 2.0.x (#95793) #95834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To align with upstream, we are requiring triton dependency to be between 2.0.0 and 2.1. This will allow PyTorch 2.0 on ROCM to stay flexible enough to pick up any performance/stability improvements from Triton, without needing to cut a separate PyTorch version. Pull Request resolved: pytorch#95793 Approved by: https://github.com/huydhn
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95834
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit e905556: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
module: rocm
atalman
approved these changes
Mar 2, 2023
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
May 3, 2023
…pytorch#95834) To align with upstream, we are requiring triton dependency to be between 2.0.0 and 2.1. This will allow PyTorch 2.0 on ROCM to stay flexible enough to pick up any performance/stability improvements from Triton, without needing to cut a separate PyTorch version. Pull Request resolved: pytorch#95793 Approved by: https://github.com/huydhn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To align with upstream, we are requiring triton dependency to be between 2.0.0 and 2.1. This will allow PyTorch 2.0 on ROCM to stay flexible enough to pick up any performance/stability improvements from Triton, without needing to cut a separate PyTorch version.
Pull Request resolved: #95793
Approved by: https://github.com/huydhn
Fixes #ISSUE_NUMBER
cc @jeffdaily @sunway513 @jithunnair-amd @pruthvistony @ROCmSupport