Skip to content

[optim] Widen the cases for defaulting to foreach #95818

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
janeyx99 wants to merge 2 commits into from
Closed

[optim] Widen the cases for defaulting to foreach #95818

janeyx99 wants to merge 2 commits into from

Conversation

@janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Mar 1, 2023 •
edited
Loading

Also added a test to verify the defaulting was as expected.

Stack from ghstack (oldest at bottom):

@janeyx99 janeyx99 requested a review from albanD as a code owner March 1, 2023 21:02
@janeyx99 janeyx99 mentioned this pull request Mar 1, 2023
Closed
@pytorch-bot pytorch-bot bot added the release notes: nn release notes category label Mar 1, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Mar 1, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95818

Note: Links to docs will display an error until the docs builds have been completed.

❌ 36 Failures

As of commit bb67cd3:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@janeyx99 janeyx99 added ciflow/trunk Trigger trunk jobs on your pull request ciflow/inductor labels Mar 1, 2023
@janeyx99
Update on "[optim] Widen the cases for defaulting to foreach"
bb67cd3 
Also added a test to verify the defaulting was as expected.




[ghstack-poisoned]
janeyx99 added a commit that referenced this pull request Mar 1, 2023
@janeyx99
[optim] Widen the cases for defaulting to foreach
fe2d761 
ghstack-source-id: 78b644d
Pull Request resolved: #95818
@janeyx99
Copy link
Contributor Author

janeyx99 commented Mar 1, 2023

Closing in favor of #95820, I accidentally did a reset --soft instead of a rebase -i

@janeyx99 janeyx99 closed this Mar 1, 2023
@facebook-github-bot facebook-github-bot deleted the gh/janeyx99/33/head branch June 8, 2023 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request release notes: nn release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@janeyx99