Skip to content

Conversation

@msaroufim
Copy link
Member

@msaroufim msaroufim commented Mar 1, 2023

This should be self containable to merge but other stuff that's been bugging me is

  • Instructions on debugging IMA issues
  • Dynamic shape instructions
  • Explaining config options better

Will look at adding a config options doc

cc @svekars @carljparker

@pytorch-bot
Copy link

pytorch-bot bot commented Mar 1, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95802

Note: Links to docs will display an error until the docs builds have been completed.

❌ 7 Failures

As of commit e300caa:

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base 5d29b68:

👉 Rebase onto the `viable/strict` branch to avoid these failures

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@msaroufim msaroufim added the module: docs Related to our documentation, both in docs/ and docblocks label Mar 1, 2023
@msaroufim msaroufim changed the title Doc Improvements ahead of 2.0 release Remove mention of dynamo.optimize() in docs Mar 1, 2023
@msaroufim msaroufim added the topic: not user facing topic category label Mar 1, 2023
@msaroufim msaroufim requested review from jansel, mlazos and svekars March 1, 2023 19:59
@msaroufim
Copy link
Member Author

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Mar 1, 2023
@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 2, 2023
This should be self containable to merge but other stuff that's been bugging me is
* Instructions on debugging IMA issues
* Dynamic shape instructions
* Explaining config options better

Will look at adding a config options doc

Pull Request resolved: pytorch/pytorch#95802
Approved by: https://github.com/svekars
msaroufim added a commit that referenced this pull request Mar 3, 2023
This should be self containable to merge but other stuff that's been bugging me is
* Instructions on debugging IMA issues
* Dynamic shape instructions
* Explaining config options better

Will look at adding a config options doc

Pull Request resolved: #95802
Approved by: https://github.com/svekars
atalman pushed a commit that referenced this pull request Mar 3, 2023
This should be self containable to merge but other stuff that's been bugging me is
* Instructions on debugging IMA issues
* Dynamic shape instructions
* Explaining config options better

Will look at adding a config options doc

Pull Request resolved: #95802
Approved by: https://github.com/svekars
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
This should be self containable to merge but other stuff that's been bugging me is
* Instructions on debugging IMA issues
* Dynamic shape instructions
* Explaining config options better

Will look at adding a config options doc

Pull Request resolved: pytorch/pytorch#95802
Approved by: https://github.com/svekars
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
This should be self containable to merge but other stuff that's been bugging me is
* Instructions on debugging IMA issues
* Dynamic shape instructions
* Explaining config options better

Will look at adding a config options doc

Pull Request resolved: pytorch/pytorch#95802
Approved by: https://github.com/svekars
pruthvistony pushed a commit to ROCm/pytorch that referenced this pull request May 3, 2023
…96007)

This should be self containable to merge but other stuff that's been bugging me is
* Instructions on debugging IMA issues
* Dynamic shape instructions
* Explaining config options better

Will look at adding a config options doc

Pull Request resolved: pytorch#95802
Approved by: https://github.com/svekars
@github-actions github-actions bot deleted the msaroufim/2.0docs branch August 31, 2024 02:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: docs Related to our documentation, both in docs/ and docblocks topic: not user facing topic category

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants