Skip to content

[MPS] Copy fixes for MPS backend #95321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
atalman merged 2 commits into from
Feb 23, 2023
Merged

[MPS] Copy fixes for MPS backend #95321

atalman merged 2 commits into from
Feb 23, 2023

Conversation

@kulinseth
Copy link
Collaborator

@kulinseth kulinseth commented Feb 22, 2023

Combination PR: #95272, #95093

  • Handle broadcasting by expanding src tensor in Copy.mm
  • Fix copy_cast_mps() on tensors with storage offset

@kulinseth kulinseth requested review from albanD and malfet February 22, 2023 21:59
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 22, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95321

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit fbd63e8:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Feb 22, 2023
@kulinseth kulinseth removed the release notes: mps Release notes category label Feb 22, 2023
@kulinseth kulinseth mentioned this pull request Feb 22, 2023
Closed
@kulinseth
Copy link
Collaborator Author

kulinseth commented Feb 23, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 23, 2023

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 23, 2023

Rebase failed due to Command git -C /home/runner/work/pytorch/pytorch rebase refs/remotes/origin/viable/strict pull/95321/head returned non-zero exit code 1

warning: skipped previously applied commit dbcd11f3a7b
warning: skipped previously applied commit 1f7ab1c823e
warning: skipped previously applied commit 0b82f588662
warning: skipped previously applied commit 91994c999f1
warning: skipped previously applied commit 7ebb3094572
warning: skipped previously applied commit 955f2b1e6ed
warning: skipped previously applied commit 419de957a31
hint: use --reapply-cherry-picks to include skipped commits
hint: Disable this message with "git config advice.skippedCherryPicks false"
Rebasing (1/4)
Auto-merging .ci/pytorch/common_utils.sh
Auto-merging .github/ci_commit_pins/xla.txt
CONFLICT (content): Merge conflict in .github/ci_commit_pins/xla.txt
error: could not apply e0c728c5454... Changes for release 2.0 only (#94934)
hint: Resolve all conflicts manually, mark them as resolved with
hint: "git add/rm <conflicted_files>", then run "git rebase --continue".
hint: You can instead skip this commit: run "git rebase --skip".
hint: To abort and get back to the state before "git rebase", run "git rebase --abort".
Could not apply e0c728c5454... Changes for release 2.0 only (#94934)

Raised by https://github.com/pytorch/pytorch/actions/runs/4254301625

kulinseth and others added 2 commits February 23, 2023 10:58
@kulinseth
[MPS] Handle broadcasting by expanding src tensor in Copy.mm (pytorch…
823c6f5 
…#95272)

Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch#95272
Approved by: https://github.com/DenisVieriu97
@razarmehr @kulinseth
[MPS] Fix copy_cast_mps() on tensors with storage offset (pytorch#95093)
fbd63e8 
- The copy_cast path requires storage_offset to be applied before casting
- This should fix some correctness issues in transformer models

Fixes pytorch#94980

Pull Request resolved: pytorch#95093
Approved by: https://github.com/kulinseth
atalman
atalman approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@atalman atalman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atalman atalman merged commit 30cf0e7 into pytorch:release/2.0 Feb 23, 2023
pruthvistony pushed a commit to ROCm/pytorch that referenced this pull request May 3, 2023
@kulinseth @razarmehr @pruthvistony
[MPS] Copy fixes for MPS backend (pytorch#95321)
6a9d26f 
* [MPS] Handle broadcasting by expanding src tensor in Copy.mm (pytorch#95272)

Fixes #ISSUE_NUMBER

Pull Request resolved: pytorch#95272
Approved by: https://github.com/DenisVieriu97

* [MPS] Fix copy_cast_mps() on tensors with storage offset (pytorch#95093)

- The copy_cast path requires storage_offset to be applied before casting
- This should fix some correctness issues in transformer models

Fixes pytorch#94980

Pull Request resolved: pytorch#95093
Approved by: https://github.com/kulinseth

---------

Co-authored-by: Ramin Azarmehr <razarmehr@apple.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

@atalman atalman atalman approved these changes

@malfet malfet Awaiting requested review from malfet

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) open source

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@kulinseth @pytorchmergebot @albanD @atalman @pytorchbot @razarmehr