[SDPA] Fix bug in parsing scaled_dot_product_attention arguments #95311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95311
Note: Links to docs will display an error until the docs builds have been completed. ❌ 3 FailuresAs of commit 2b21157: NEW FAILURES - The following jobs have failed:
BROKEN TRUNK - The following jobs failed but were present on the merge base 8de4238:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
cpuhrsch
approved these changes
Feb 22, 2023
bdhirsh
reviewed
Feb 22, 2023
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 1 mandatory check(s) failed. The first few are: Dig deeper by viewing the failures on hud |
drisspg
changed the title
Contributor
Author
|
@pytorchbot merge -f "unrelated failures" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 23, 2023
…311) Fixes #95266 Pull Request resolved: pytorch/pytorch#95311 Approved by: https://github.com/cpuhrsch
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 23, 2023
…311) Fixes #95266 Pull Request resolved: pytorch/pytorch#95311 Approved by: https://github.com/cpuhrsch
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 23, 2023
…311) Fixes #95266 Pull Request resolved: pytorch/pytorch#95311 Approved by: https://github.com/cpuhrsch
drisspg
added a commit
to drisspg/pytorch
that referenced
this pull request
Feb 23, 2023
…orch#95311) Fixes pytorch#95266 Pull Request resolved: pytorch#95311 Approved by: https://github.com/cpuhrsch
atalman
pushed a commit
that referenced
this pull request
Feb 24, 2023
) (#95397) Fixes #95266 Pull Request resolved: #95311 Approved by: https://github.com/cpuhrsch
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 25, 2023
…311) Fixes #95266 Pull Request resolved: pytorch/pytorch#95311 Approved by: https://github.com/cpuhrsch
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Feb 25, 2023
…311) Fixes #95266 Pull Request resolved: pytorch/pytorch#95311 Approved by: https://github.com/cpuhrsch
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
…311) Fixes #95266 Pull Request resolved: pytorch/pytorch#95311 Approved by: https://github.com/cpuhrsch
pruthvistony
added a commit
to ROCm/pytorch
that referenced
this pull request
May 2, 2023
…nts (pytorch#95311)" This reverts commit 29c235e.
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
May 3, 2023
…orch#95311) (pytorch#95397) Fixes pytorch#95266 Pull Request resolved: pytorch#95311 Approved by: https://github.com/cpuhrsch
jhavukainen
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Mar 15, 2024
…orch#95311) Fixes pytorch#95266 Pull Request resolved: pytorch#95311 Approved by: https://github.com/cpuhrsch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #95266
cc @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire