[MPS] Handle broadcasting by expanding src tensor in Copy.mm #95272
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95272
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5ae834a: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/mps
Collaborator
Author
|
@pytorchbot merge -f "All tests are green." |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
kulinseth
added a commit
to kulinseth/pytorch
that referenced
this pull request
Feb 22, 2023
…#95272) Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#95272 Approved by: https://github.com/DenisVieriu97
This was referenced Feb 22, 2023
kulinseth
added a commit
to kulinseth/pytorch
that referenced
this pull request
Feb 23, 2023
…#95272) Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#95272 Approved by: https://github.com/DenisVieriu97
atalman
pushed a commit
that referenced
this pull request
Feb 23, 2023
* [MPS] Handle broadcasting by expanding src tensor in Copy.mm (#95272) Fixes #ISSUE_NUMBER Pull Request resolved: #95272 Approved by: https://github.com/DenisVieriu97 * [MPS] Fix copy_cast_mps() on tensors with storage offset (#95093) - The copy_cast path requires storage_offset to be applied before casting - This should fix some correctness issues in transformer models Fixes #94980 Pull Request resolved: #95093 Approved by: https://github.com/kulinseth --------- Co-authored-by: Ramin Azarmehr <razarmehr@apple.com>
cyyever
pushed a commit
to cyyever/pytorch_private
that referenced
this pull request
Mar 5, 2023
Fixes #ISSUE_NUMBER Pull Request resolved: pytorch/pytorch#95272 Approved by: https://github.com/DenisVieriu97
pruthvistony
added a commit
to ROCm/pytorch
that referenced
this pull request
May 2, 2023
…ytorch#95272)" This reverts commit 02a6d43.
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
May 3, 2023
* [MPS] Handle broadcasting by expanding src tensor in Copy.mm (pytorch#95272) Fixes #ISSUE_NUMBER Pull Request resolved: pytorch#95272 Approved by: https://github.com/DenisVieriu97 * [MPS] Fix copy_cast_mps() on tensors with storage offset (pytorch#95093) - The copy_cast path requires storage_offset to be applied before casting - This should fix some correctness issues in transformer models Fixes pytorch#94980 Pull Request resolved: pytorch#95093 Approved by: https://github.com/kulinseth --------- Co-authored-by: Ramin Azarmehr <razarmehr@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #ISSUE_NUMBER