Raise error on 3.11 dynamo export #95088
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@pytorchbot merge -f "unrelated test failures" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
williamwen42
added a commit
that referenced
this pull request
Feb 23, 2023
For #94914. Realized that `dynamo.export` doesn't immediately raise an error when dynamo is trying to run on 3.11/windows. Pull Request resolved: #95088 Approved by: https://github.com/weiwangmeta
williamwen42
added a commit
that referenced
this pull request
Feb 23, 2023
For #94914. Realized that `dynamo.export` doesn't immediately raise an error when dynamo is trying to run on 3.11/windows. Pull Request resolved: #95088 Approved by: https://github.com/weiwangmeta
williamwen42
added a commit
that referenced
this pull request
Feb 23, 2023
For #94914. Realized that `dynamo.export` doesn't immediately raise an error when dynamo is trying to run on 3.11/windows. Pull Request resolved: #95088 Approved by: https://github.com/weiwangmeta
atalman
pushed a commit
that referenced
this pull request
Feb 23, 2023
For #94914. Realized that `dynamo.export` doesn't immediately raise an error when dynamo is trying to run on 3.11/windows. Pull Request resolved: #95088 Approved by: https://github.com/weiwangmeta
pruthvistony
added a commit
to ROCm/pytorch
that referenced
this pull request
May 2, 2023
This reverts commit 8928e7b.
pruthvistony
pushed a commit
to ROCm/pytorch
that referenced
this pull request
May 3, 2023
For pytorch#94914. Realized that `dynamo.export` doesn't immediately raise an error when dynamo is trying to run on 3.11/windows. Pull Request resolved: pytorch#95088 Approved by: https://github.com/weiwangmeta
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #94914. Realized that
dynamo.exportdoesn't immediately raise an error when dynamo is trying to run on 3.11/windows.cc @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire