Skip to content

[profiler] update docs with repeat=1 #95085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
davidberard98 wants to merge 2 commits into from
Closed

[profiler] update docs with repeat=1 #95085

davidberard98 wants to merge 2 commits into from

Conversation

@davidberard98
Copy link
Contributor

@davidberard98 davidberard98 commented Feb 17, 2023 •
edited by pytorchmergebot
Loading

Stack from ghstack (oldest at bottom):

Specifying number of times to repeat is now required when defining the schedule.

@davidberard98
[profiler] update docs with repeat=1
34f023d 
I think it may be required now to specify repeat=1

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 17, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/95085

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 06c996b:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

davidberard98 added a commit that referenced this pull request Feb 17, 2023
@davidberard98
[profiler] update docs with repeat=1
8a7acec 
I think it may be required now to specify repeat=1

ghstack-source-id: a651ca9
Pull Request resolved: #95085
@davidberard98 davidberard98 added release notes: profiler release notes category topic: docs topic category labels Feb 17, 2023
@davidberard98 davidberard98 marked this pull request as ready for review February 17, 2023 23:56
aaronenyeshi
aaronenyeshi approved these changes Feb 20, 2023
View reviewed changes
Copy link
Member

@aaronenyeshi aaronenyeshi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding this!

@davidberard98
Copy link
Contributor Author

davidberard98 commented Feb 21, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 21, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 21, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 21, 2023

Merge failed

Reason: 2 mandatory check(s) failed. The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job Failing merge rule: Core Maintainers

@davidberard98
Copy link
Contributor Author

davidberard98 commented Feb 21, 2023

@pytorchbot rebase -s

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 21, 2023

@pytorchbot successfully started a rebase job. Check the current status here

@davidberard98
Update on "[profiler] update docs with repeat=1"
06c996b 
Specifying number of times to repeat is now required when defining the schedule.

[ghstack-poisoned]
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 21, 2023

Successfully rebased gh/davidberard98/169/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/95085)

pytorchmergebot pushed a commit that referenced this pull request Feb 21, 2023
@davidberard98
[profiler] update docs with repeat=1
18430c5 
I think it may be required now to specify repeat=1

ghstack-source-id: 2d7650c
Pull Request resolved: #95085
@davidberard98
Copy link
Contributor Author

davidberard98 commented Feb 21, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 21, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

davidberard98 added a commit to davidberard98/pytorch that referenced this pull request Feb 21, 2023
@davidberard98
[profiler] update docs with repeat=1 (pytorch#95085)
3f337c9 
Specifying number of times to repeat is now required when defining the schedule.
Pull Request resolved: pytorch#95085
Approved by: https://github.com/aaronenyeshi
This was referenced Feb 21, 2023
Merged
Closed
weiwangmeta pushed a commit that referenced this pull request Feb 23, 2023
@davidberard98
[profiler] update docs with repeat=1 (#95085) (#95242)
0553b46 
Specifying number of times to repeat is now required when defining the schedule.
Pull Request resolved: #95085
Approved by: https://github.com/aaronenyeshi
@msaroufim msaroufim mentioned this pull request Mar 3, 2023
Closed
cyyever pushed a commit to cyyever/pytorch_private that referenced this pull request Mar 5, 2023
@davidberard98 @cyyever
[profiler] update docs with repeat=1 (#95085)
87468a2 
Specifying number of times to repeat is now required when defining the schedule.
Pull Request resolved: pytorch/pytorch#95085
Approved by: https://github.com/aaronenyeshi
pruthvistony added a commit to ROCm/pytorch that referenced this pull request May 2, 2023
@pruthvistony
Revert "[profiler] update docs with repeat=1 (pytorch#95085)"
efc9880 
This reverts commit ed4b6d2.
pruthvistony pushed a commit to ROCm/pytorch that referenced this pull request May 3, 2023
@davidberard98 @pruthvistony
[profiler] update docs with repeat=1 (pytorch#95085) (pytorch#95242)
0917cf0 
Specifying number of times to repeat is now required when defining the schedule.
Pull Request resolved: pytorch#95085
Approved by: https://github.com/aaronenyeshi
@facebook-github-bot facebook-github-bot deleted the gh/davidberard98/169/head branch June 8, 2023 16:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaronenyeshi aaronenyeshi aaronenyeshi approved these changes

@chaekit chaekit Awaiting requested review from chaekit

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: profiler release notes category topic: docs topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@davidberard98 @pytorchmergebot @aaronenyeshi