Fix byte ordering issue in from_numpy #9508
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishwakftw
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
Contributor
Author
|
Windows build failure looks weird: |
Contributor
Author
|
@pytorchbot retest this please |
Contributor
|
@vishwakftw is this ready for review? |
Contributor
Author
|
@weiyangfb Yes, it is. |
weiyangfb
added
the
ready for review (this tag is deprecated)
Contributor
Author
|
Is this good to go? |
Contributor
Author
|
@pytorchbot retest this please |
Contributor
Author
|
@weiyangfb Is this good to go? |
Contributor
|
@colesbury @gchanan Would you like to take a look at this? |
Contributor
Author
|
@weiyangfb is this good to go? Sorry about continuous reminders. |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
weiyangfb has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
soumith
approved these changes
Aug 14, 2018
Contributor
|
lgtm, sorry for the delay in review. |
Contributor
Author
|
Thank you, and no worries. |
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Fixes pytorch#3671 . Pull Request resolved: pytorch#9508 Differential Revision: D9307186 Pulled By: soumith fbshipit-source-id: 39dcaa6fd2d330d7085802acd6f63c19270164fa
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3671 .