Skip to content

[tp] minor update to TP docs #94748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wanchaol wants to merge 2 commits into from
Closed

[tp] minor update to TP docs #94748

wanchaol wants to merge 2 commits into from

Conversation

@wanchaol
Copy link
Collaborator

@wanchaol wanchaol commented Feb 13, 2023 •
edited
Loading

Stack from ghstack (oldest at bottom):

minor update to TP docs for beta release

@wanchaol
[tp] minor update to TP docs
2241011 
minor update to TP docs for beta release

[ghstack-poisoned]
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 13, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94748

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 5475077:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@wanchaol wanchaol added the release notes: distributed (dtensor) release notes category label Feb 13, 2023
fduwjj
fduwjj approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@fduwjj fduwjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wanchaol
Update on "[tp] minor update to TP docs"
5475077 
minor update to TP docs for beta release

[ghstack-poisoned]
wanchaol added a commit that referenced this pull request Feb 13, 2023
@wanchaol
[tp] minor update to TP docs
3c06981 
minor update to TP docs for beta release

ghstack-source-id: bc9e8b0
Pull Request resolved: #94748
@wanchaol wanchaol added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 13, 2023
@wanchaol
Copy link
Collaborator Author

wanchaol commented Feb 13, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 13, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 13, 2023

Merge failed

Reason: 1 jobs have failed, first few of them are: trunk / win-vs2019-cuda11.7-py3 / test (default, 3, 5, windows.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@wanchaol
Copy link
Collaborator Author

wanchaol commented Feb 13, 2023

@pytorchbot merge -f "failure unrelated"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 13, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/wanchaol/260/head branch June 8, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fduwjj fduwjj fduwjj approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@fegin fegin Awaiting requested review from fegin

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (dtensor) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wanchaol @pytorchmergebot @fduwjj