Skip to content

[ONNX] Remove the deprecated monkey patches to torch.Graph #94747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
justinchuby wants to merge 2 commits into from
Closed

[ONNX] Remove the deprecated monkey patches to torch.Graph #94747

justinchuby wants to merge 2 commits into from

Conversation

@justinchuby
Copy link
Collaborator

@justinchuby justinchuby commented Feb 13, 2023 •
edited
Loading

@justinchuby justinchuby mentioned this pull request Feb 13, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 13, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94747

Note: Links to docs will display an error until the docs builds have been completed.

❌ 2 Failures

As of commit 6df7741:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: onnx torch.onnx related changes that should show up in the release notes label Feb 13, 2023
@justinchuby justinchuby added this to the 2.0.0 milestone Feb 13, 2023
@justinchuby justinchuby added module: onnx Related to torch.onnx module: bc-breaking Related to a BC-breaking change topic: bc breaking topic category labels Feb 13, 2023
justinchuby added a commit that referenced this pull request Feb 13, 2023
@justinchuby
[ONNX] Remove the deprecated monkey patches to torch.Graph
0a9eb0c 
ghstack-source-id: 48ce7f5
Pull Request resolved: #94747

Signed-off-by: Justin Chu <justinchu@microsoft.com>
@justinchuby justinchuby removed the module: bc-breaking Related to a BC-breaking change label Feb 13, 2023
@justinchuby
Copy link
Collaborator Author

justinchuby commented Feb 13, 2023

@pytorchbot merge -g

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 13, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 13, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 13, 2023

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_8-cuda11_7-with-pypi-cudnn-test / test

Details for Dev Infra team Raised by workflow job

@justinchuby
Copy link
Collaborator Author

justinchuby commented Feb 14, 2023

@pytorchbot merge -f "flaky cudnn test"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 14, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/justinchuby/31/head branch June 8, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@BowenBao BowenBao BowenBao approved these changes

@abock abock Awaiting requested review from abock

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: onnx Related to torch.onnx open source release notes: onnx torch.onnx related changes that should show up in the release notes topic: bc breaking topic category

Projects

None yet

Milestone

2.0.0

Development

Successfully merging this pull request may close these issues.

6 participants

@justinchuby @pytorchmergebot @Skylion007 @BowenBao @pytorchbot