Skip to content

[MPS] Add sort and argSort Op. #94697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kulinseth wants to merge 5 commits into from
Closed

[MPS] Add sort and argSort Op. #94697

kulinseth wants to merge 5 commits into from

Conversation

@kulinseth
Copy link
Collaborator

@kulinseth kulinseth commented Feb 12, 2023

Fixes #ISSUE_NUMBER

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 12, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94697

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit da37aad:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Feb 12, 2023
DenisVieriu97
DenisVieriu97 approved these changes Feb 12, 2023
View reviewed changes
Copy link
Collaborator

@DenisVieriu97 DenisVieriu97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@kulinseth kulinseth requested a review from a team as a code owner February 12, 2023 06:56
@kulinseth
Copy link
Collaborator Author

kulinseth commented Feb 13, 2023

@pytorchbot merge -f "MPS tests are green."

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 13, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

This was referenced Feb 13, 2023
Closed
Closed
@kulinseth kulinseth mentioned this pull request Mar 4, 2023
Closed
liuliu
liuliu reviewed Apr 18, 2025
View reviewed changes
aten/src/ATen/native/mps/operations/Sort.mm
descending:(BOOL)descending
name:@"sort_out"];
sortedTensor = castFromIHFTypes(mpsGraph, sortedTensor, values);
MPSGraphTensor* argSortedTensor = [mpsGraph argSortWithTensor:castInputTensor
Copy link

@liuliu liuliu Apr 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it correct understanding that MPSGraph internally will fuse these two together? I noticed that in [mpsGraph dump], the mps.sort IR emit two outputs (values, indices) while these two methods (sortWithTensor / argSortWithTensor) only extract one from that mps.sort inst. I imagine internally these two duplicate mps.sort will get de-duped through CSE?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DenisVieriu97 DenisVieriu97 DenisVieriu97 approved these changes

@razarmehr razarmehr Awaiting requested review from razarmehr

+1 more reviewer

@liuliu liuliu liuliu left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged open source release notes: mps Release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kulinseth @pytorchmergebot @liuliu @DenisVieriu97 @pytorchbot