[pytorch] Add support for "height" and "width" dimension for the "select" operator on pytorch vulkan backend #94612
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94612
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit bbce3e4: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43020796 |
SS-JIA
approved these changes
Feb 10, 2023
Contributor
Author
|
/easycla |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43020796 |
yipjustin
force-pushed
the
export-D43020796
branch
from
e6890ea to
42f795a
Compare
Contributor
Author
|
/easycla |
Contributor
|
This pull request was exported from Phabricator. Differential Revision: D43020796 |
yipjustin
added a commit
to yipjustin/pytorch
that referenced
this pull request
Feb 13, 2023
…ect" operator on pytorch vulkan backend (pytorch#94612) Summary: Pull Request resolved: pytorch#94612 Add support for "height" and "width" dimension for the "select" operator on pytorch vulkan backend. Test Plan: ``` yipjustin@yipjustin-mbp fbsource % buck run -c pt.vulkan_full_precision=1 --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -- --gtest_filter="*select_3d*" Downloaded 1/2 artifacts, 1.29 Mbytes, 0.0% cache miss (for updated rules) Building: finished in 3.7 sec (100%) 450/450 jobs, 2/450 updated Total time: 3.8 sec BUILD SUCCEEDED Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc Note: Google Test filter = *select_3d* [==========] Running 9 tests from 1 test suite. [----------] Global test environment set-up. [----------] 9 tests from VulkanAPITest [ RUN ] VulkanAPITest.select_3d_depth_small [ OK ] VulkanAPITest.select_3d_depth_small (30 ms) [ RUN ] VulkanAPITest.select_3d_depth_medium [ OK ] VulkanAPITest.select_3d_depth_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_depth_large [ OK ] VulkanAPITest.select_3d_depth_large (1 ms) [ RUN ] VulkanAPITest.select_3d_height_small [ OK ] VulkanAPITest.select_3d_height_small (0 ms) [ RUN ] VulkanAPITest.select_3d_height_medium [ OK ] VulkanAPITest.select_3d_height_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_height_large [ OK ] VulkanAPITest.select_3d_height_large (3 ms) [ RUN ] VulkanAPITest.select_3d_width_small [ OK ] VulkanAPITest.select_3d_width_small (0 ms) [ RUN ] VulkanAPITest.select_3d_width_medium [ OK ] VulkanAPITest.select_3d_width_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_width_large [ OK ] VulkanAPITest.select_3d_width_large (1 ms) [----------] 9 tests from VulkanAPITest (40 ms total) [----------] Global test environment tear-down [==========] 9 tests from 1 test suite ran. (40 ms total) [ PASSED ] 9 tests. ``` Reviewed By: SS-JIA Differential Revision: D43020796 fbshipit-source-id: 7cf725e07e8ae5b898a6fe951a00cecf34f133ce
yipjustin
force-pushed
the
export-D43020796
branch
from
42f795a to
79927f3
Compare
Contributor
|
@yipjustin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 1 jobs have failed, first few of them are: linux-binary-manywheel / manywheel-py3_8-cuda11_7-with-pypi-cudnn-test / test Details for Dev Infra teamRaised by workflow job |
Contributor
Author
|
Ignoring the two failures as they are unlikely to be related to this change. @SS-JIA @pytorchbot merge -f |
|
❌ 🤖 pytorchbot command failed: Try |
Contributor
Author
|
@pytorchmergebot merge -f "Ignoring the two failures as they are unlikely to be related to this change." |
|
You are not authorized to force merges to this repository. Please use the regular |
Contributor
Author
|
@pytorchmergebot merge -f "Ignoring the two failures as they are unlikely to be related to this change." |
|
You are not authorized to force merges to this repository. Please use the regular |
Contributor
Author
|
@pytorchbot rebase |
|
You don't have permissions to rebase this PR since you are a first time contributor. If you think this is a mistake, please contact PyTorch Dev Infra. |
Contributor
|
@pytorchbot rebase |
Collaborator
|
@pytorchbot successfully started a rebase job. Check the current status here |
…ect" operator on pytorch vulkan backend (pytorch#94612) Summary: Pull Request resolved: pytorch#94612 Add support for "height" and "width" dimension for the "select" operator on pytorch vulkan backend. Test Plan: ``` yipjustin@yipjustin-mbp fbsource % buck run -c pt.vulkan_full_precision=1 --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -- --gtest_filter="*select_3d*" Downloaded 1/2 artifacts, 1.29 Mbytes, 0.0% cache miss (for updated rules) Building: finished in 3.7 sec (100%) 450/450 jobs, 2/450 updated Total time: 3.8 sec BUILD SUCCEEDED Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc Note: Google Test filter = *select_3d* [==========] Running 9 tests from 1 test suite. [----------] Global test environment set-up. [----------] 9 tests from VulkanAPITest [ RUN ] VulkanAPITest.select_3d_depth_small [ OK ] VulkanAPITest.select_3d_depth_small (30 ms) [ RUN ] VulkanAPITest.select_3d_depth_medium [ OK ] VulkanAPITest.select_3d_depth_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_depth_large [ OK ] VulkanAPITest.select_3d_depth_large (1 ms) [ RUN ] VulkanAPITest.select_3d_height_small [ OK ] VulkanAPITest.select_3d_height_small (0 ms) [ RUN ] VulkanAPITest.select_3d_height_medium [ OK ] VulkanAPITest.select_3d_height_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_height_large [ OK ] VulkanAPITest.select_3d_height_large (3 ms) [ RUN ] VulkanAPITest.select_3d_width_small [ OK ] VulkanAPITest.select_3d_width_small (0 ms) [ RUN ] VulkanAPITest.select_3d_width_medium [ OK ] VulkanAPITest.select_3d_width_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_width_large [ OK ] VulkanAPITest.select_3d_width_large (1 ms) [----------] 9 tests from VulkanAPITest (40 ms total) [----------] Global test environment tear-down [==========] 9 tests from 1 test suite ran. (40 ms total) [ PASSED ] 9 tests. ``` Reviewed By: SS-JIA Differential Revision: D43020796 fbshipit-source-id: 7cf725e07e8ae5b898a6fe951a00cecf34f133ce
Collaborator
|
Successfully rebased |
pytorchmergebot
force-pushed
the
export-D43020796
branch
from
79927f3 to
bbce3e4
Compare
Contributor
|
@yipjustin has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
drisspg
pushed a commit
to drisspg/pytorch
that referenced
this pull request
Feb 16, 2023
…ect" operator on pytorch vulkan backend (pytorch#94612) Summary: Add support for "height" and "width" dimension for the "select" operator on pytorch vulkan backend. Test Plan: ``` yipjustin@yipjustin-mbp fbsource % buck run -c pt.vulkan_full_precision=1 --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -- --gtest_filter="*select_3d*" Downloaded 1/2 artifacts, 1.29 Mbytes, 0.0% cache miss (for updated rules) Building: finished in 3.7 sec (100%) 450/450 jobs, 2/450 updated Total time: 3.8 sec BUILD SUCCEEDED Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc Note: Google Test filter = *select_3d* [==========] Running 9 tests from 1 test suite. [----------] Global test environment set-up. [----------] 9 tests from VulkanAPITest [ RUN ] VulkanAPITest.select_3d_depth_small [ OK ] VulkanAPITest.select_3d_depth_small (30 ms) [ RUN ] VulkanAPITest.select_3d_depth_medium [ OK ] VulkanAPITest.select_3d_depth_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_depth_large [ OK ] VulkanAPITest.select_3d_depth_large (1 ms) [ RUN ] VulkanAPITest.select_3d_height_small [ OK ] VulkanAPITest.select_3d_height_small (0 ms) [ RUN ] VulkanAPITest.select_3d_height_medium [ OK ] VulkanAPITest.select_3d_height_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_height_large [ OK ] VulkanAPITest.select_3d_height_large (3 ms) [ RUN ] VulkanAPITest.select_3d_width_small [ OK ] VulkanAPITest.select_3d_width_small (0 ms) [ RUN ] VulkanAPITest.select_3d_width_medium [ OK ] VulkanAPITest.select_3d_width_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_width_large [ OK ] VulkanAPITest.select_3d_width_large (1 ms) [----------] 9 tests from VulkanAPITest (40 ms total) [----------] Global test environment tear-down [==========] 9 tests from 1 test suite ran. (40 ms total) [ PASSED ] 9 tests. ``` Reviewed By: SS-JIA Differential Revision: D43020796 Pull Request resolved: pytorch#94612 Approved by: https://github.com/SS-JIA
pruthvistony
added a commit
to ROCm/pytorch
that referenced
this pull request
May 2, 2023
…the "select" operator on pytorch vulkan backend (pytorch#94612)" This reverts commit f2c2642.
jhavukainen
pushed a commit
to kulinseth/pytorch
that referenced
this pull request
Mar 15, 2024
…ect" operator on pytorch vulkan backend (pytorch#94612) Summary: Add support for "height" and "width" dimension for the "select" operator on pytorch vulkan backend. Test Plan: ``` yipjustin@yipjustin-mbp fbsource % buck run -c pt.vulkan_full_precision=1 --target-platforms ovr_config//platform/macos:arm64-fbsource //xplat/caffe2:pt_vulkan_api_test_binAppleMac\#macosx-arm64 -- --gtest_filter="*select_3d*" Downloaded 1/2 artifacts, 1.29 Mbytes, 0.0% cache miss (for updated rules) Building: finished in 3.7 sec (100%) 450/450 jobs, 2/450 updated Total time: 3.8 sec BUILD SUCCEEDED Running main() from xplat/third-party/gmock/googletest-1.12.1/googletest/src/gtest_main.cc Note: Google Test filter = *select_3d* [==========] Running 9 tests from 1 test suite. [----------] Global test environment set-up. [----------] 9 tests from VulkanAPITest [ RUN ] VulkanAPITest.select_3d_depth_small [ OK ] VulkanAPITest.select_3d_depth_small (30 ms) [ RUN ] VulkanAPITest.select_3d_depth_medium [ OK ] VulkanAPITest.select_3d_depth_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_depth_large [ OK ] VulkanAPITest.select_3d_depth_large (1 ms) [ RUN ] VulkanAPITest.select_3d_height_small [ OK ] VulkanAPITest.select_3d_height_small (0 ms) [ RUN ] VulkanAPITest.select_3d_height_medium [ OK ] VulkanAPITest.select_3d_height_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_height_large [ OK ] VulkanAPITest.select_3d_height_large (3 ms) [ RUN ] VulkanAPITest.select_3d_width_small [ OK ] VulkanAPITest.select_3d_width_small (0 ms) [ RUN ] VulkanAPITest.select_3d_width_medium [ OK ] VulkanAPITest.select_3d_width_medium (0 ms) [ RUN ] VulkanAPITest.select_3d_width_large [ OK ] VulkanAPITest.select_3d_width_large (1 ms) [----------] 9 tests from VulkanAPITest (40 ms total) [----------] Global test environment tear-down [==========] 9 tests from 1 test suite ran. (40 ms total) [ PASSED ] 9 tests. ``` Reviewed By: SS-JIA Differential Revision: D43020796 Pull Request resolved: pytorch#94612 Approved by: https://github.com/SS-JIA
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Add support for "height" and "width" dimension for the "select" operator on pytorch vulkan backend.
Test Plan:
Reviewed By: SS-JIA
Differential Revision: D43020796