[dtensor] remove typing hack of DeviceMesh #94526
Conversation
This removes the typing hack, part of #92931 [ghstack-poisoned]
wanchaol
requested review from
H-Huang,
awgu,
fegin,
kwen2501,
mrshenli,
rohan-varma and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94526
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 2e410ef: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This removes the typing hack, part of #92931 [ghstack-poisoned]
This removes the typing hack, part of #92931 [ghstack-poisoned]
|
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
|
@pytorchbot revert -m "breaking internal builds" -c ghfirst |
|
Is #97889 a forward fix? |
|
@pytorchbot successfully started a revert job. Check the current status here. |
|
@wanchaol your PR has been successfully reverted. |
This reverts commit 70b063d. Reverted #94526 on behalf of https://github.com/atalman due to breaking internal builds
yeah but looks a bit tricky to get the forward fix internally :(, I will rebase |
…ard type imports" This PR relands #94526 and tries to guard the type import for older version numpy [ghstack-poisoned]
This PR relands #94526 and tries to guard the type import for older version numpy [ghstack-poisoned]
This PR relands #94526 and tries to guard the type import for older version numpy Pull Request resolved: #97889 Approved by: https://github.com/fegin
Stack from ghstack (oldest at bottom):
This removes the typing hack, part of #92931