Skip to content

[reland] add numpy typing plugin to mypy config #94525

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wanchaol wants to merge 3 commits into from
Closed

[reland] add numpy typing plugin to mypy config #94525

wanchaol wants to merge 3 commits into from

Conversation

@wanchaol
Copy link
Collaborator

@wanchaol wanchaol commented Feb 9, 2023 •
edited
Loading

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Feb 9, 2023
This was referenced Feb 9, 2023
Closed
Closed
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 9, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94525

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit efd0b1f:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@wanchaol wanchaol added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 9, 2023
@Skylion007 Skylion007 self-requested a review February 20, 2023 18:42
Skylion007
Skylion007 requested changes Feb 20, 2023
View reviewed changes
Copy link
Collaborator

@Skylion007 Skylion007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, to not fail on reland, I think it needs to have a minimum numpy version (1.20) for numpy typing.

@wanchaol wanchaol requested a review from Skylion007 March 28, 2023 17:46
@wanchaol
Copy link
Collaborator Author

wanchaol commented Mar 28, 2023

Hmm, to not fail on reland, I think it needs to have a minimum numpy version (1.20) for numpy typing.

@Skylion007 Thanks! I updated the old CI to a newer numpy version, it's ready for another review :)

@wanchaol wanchaol requested review from a team and malfet March 28, 2023 19:39
huydhn
huydhn approved these changes Mar 29, 2023
View reviewed changes
Copy link
Contributor

@huydhn huydhn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! If you wonder where the heck Windows numpy comes from, it's from here https://github.com/pytorch/test-infra/blob/main/aws/ami/windows/scripts/Installers/Install-Conda-Dependencies.ps1#L17

@wanchaol
Copy link
Collaborator Author

wanchaol commented Mar 29, 2023

LGTM! If you wonder where the heck Windows numpy comes from, it's from here https://github.com/pytorch/test-infra/blob/main/aws/ami/windows/scripts/Installers/Install-Conda-Dependencies.ps1#L17

thanks @huydhn! Shall we worry about windows numpy version, I saw the version is < 1.23 so I think it should still looks good to us?

@huydhn
Copy link
Contributor

huydhn commented Mar 29, 2023

thanks @huydhn! Shall we worry about windows numpy version, I saw the version is < 1.23 so I think it should still looks good to us?

I think we are good. I double check. Windows has numpy==1.21.5

@huydhn huydhn mentioned this pull request Apr 4, 2023
Open
@facebook-github-bot facebook-github-bot deleted the gh/wanchaol/257/head branch June 8, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@huydhn huydhn huydhn approved these changes

@Skylion007 Skylion007 Awaiting requested review from Skylion007

@malfet malfet Awaiting requested review from malfet

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged topic: not user facing topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wanchaol @huydhn @Skylion007 @pytorchmergebot