Skip to content

[MPS] Casting int64 to int32 for reduction ops and raise warning. #94484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kulinseth wants to merge 1 commit into from
Closed

[MPS] Casting int64 to int32 for reduction ops and raise warning. #94484

kulinseth wants to merge 1 commit into from

Conversation

@kulinseth
Copy link
Collaborator

@kulinseth kulinseth commented Feb 9, 2023 •
edited
Loading

Currently casting it as a workaround till we have full support in OS.
Fixes ##88319 (comment)

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 9, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94484

Note: Links to docs will display an error until the docs builds have been completed.

❗ 1 Active SEVs

There are 1 currently active SEVs. If your PR is affected, please view them below:

✅ No Failures

As of commit 3b24631:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Feb 9, 2023
@ezyang ezyang requested a review from albanD February 9, 2023 12:45
@ezyang ezyang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 9, 2023
@kulinseth
Copy link
Collaborator Author

kulinseth commented Feb 9, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 9, 2023

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 9, 2023

Successfully rebased reduction_int64 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout reduction_int64 && git pull --rebase)

razarmehr
razarmehr approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@razarmehr razarmehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kulinseth
Copy link
Collaborator Author

kulinseth commented Feb 10, 2023

@pytorchbot merge -f "MPS tests are green."

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 10, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@razarmehr razarmehr razarmehr approved these changes

@DenisVieriu97 DenisVieriu97 Awaiting requested review from DenisVieriu97

@albanD albanD Awaiting requested review from albanD

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged open source release notes: mps Release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@kulinseth @pytorchmergebot @razarmehr @ezyang @pytorchbot