Skip to content

[DCP]Update optimizer.py docstring #94379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wz337 wants to merge 1 commit into from
Closed

[DCP]Update optimizer.py docstring #94379

wz337 wants to merge 1 commit into from

Conversation

@wz337
Copy link
Contributor

@wz337 wz337 commented Feb 8, 2023

Update load_sharded_optimizer_state_dict() docstring.

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 8, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94379

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit db64433:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@wz337 wz337 marked this pull request as ready for review February 8, 2023 06:56
@wz337 wz337 requested a review from kumpera February 8, 2023 06:57
fduwjj
fduwjj approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@fduwjj fduwjj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and please make sure CI all passes.

Thanks!

@wz337
Copy link
Contributor Author

wz337 commented Feb 8, 2023

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 8, 2023

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 8, 2023

Successfully rebased update_optimizer_docstring_only onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout update_optimizer_docstring_only && git pull --rebase)

@wz337
Copy link
Contributor Author

wz337 commented Feb 9, 2023

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 9, 2023

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 9, 2023

Successfully rebased update_optimizer_docstring_only onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout update_optimizer_docstring_only && git pull --rebase)

@wz337
Copy link
Contributor Author

wz337 commented Feb 9, 2023

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 9, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 9, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fduwjj fduwjj fduwjj approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@wanchaol wanchaol Awaiting requested review from wanchaol

@kumpera kumpera Awaiting requested review from kumpera

@fegin fegin Awaiting requested review from fegin

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wz337 @pytorchmergebot @fduwjj