Print fqn in the warning message #94313
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaojuanmao
requested review from
H-Huang,
awgu,
kwen2501,
mrshenli and
rohan-varma
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94313
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 5bd9ef8: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
zhaojuanmao
requested review from
H-Huang,
awgu,
fegin,
kwen2501,
mrshenli,
rohan-varma and
wanchaol
and removed request for
H-Huang,
awgu,
kwen2501,
mrshenli,
rohan-varma and
wanchaol
fegin
requested changes
Feb 7, 2023
zhaojuanmao
force-pushed
the
errorMessage
branch
from
52b5a7c to
a179e82
Compare
fegin
approved these changes
Feb 7, 2023
Contributor
fegin
left a comment
fegin
left a comment
There was a problem hiding this comment.
Thanks for the PR. Linter has some errors.
awgu
reviewed
Feb 7, 2023
Collaborator
awgu
left a comment
awgu
left a comment
There was a problem hiding this comment.
I think we need to move the f to the line with the { ... } to print the correct string and fix the lint.
zhaojuanmao
force-pushed
the
errorMessage
branch
from
a179e82 to
5bd9ef8
Compare
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print fqn in the warning message, also make "else" match with the "if" in _apply_to_modules()