Skip to content

[functorch] linearize #94173

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
kshitij12345 wants to merge 11 commits into from
Closed

[functorch] linearize #94173

kshitij12345 wants to merge 11 commits into from

Conversation

@kshitij12345
Copy link
Collaborator

@kshitij12345 kshitij12345 commented Feb 6, 2023 •
edited
Loading

Fixes pytorch/functorch#724

TODO:

  • Docs

NOTE: const_fold pass raises UserWarning -> #94374

cc @zou3519 @Chillee @samdow @soumith @janeyx99

@pytorch-bot
Copy link

pytorch-bot bot commented Feb 6, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94173

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit e661335:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the release notes: fx release notes category label Feb 6, 2023
@kshitij12345 kshitij12345 marked this pull request as ready for review February 6, 2023 11:57
@kshitij12345 kshitij12345 requested a review from Chillee February 6, 2023 11:57
@kshitij12345 kshitij12345 added module: functorch Pertaining to torch.func or pytorch/functorch release notes: torch.func release notes category for torch.vmap or torch.func.* APIs labels Feb 7, 2023
@soulitzer soulitzer added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Feb 8, 2023
Chillee
Chillee approved these changes Feb 8, 2023
View reviewed changes
Copy link
Collaborator

@Chillee Chillee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

torch/_functorch/eager_transforms.py
return tangents

jvp_graph = make_fx(trace_fn)(flat_tangents)
const_folded_jvp_graph = const_fold.split_const_subgraphs(jvp_graph)
Copy link
Collaborator

@Chillee Chillee Feb 8, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm... looking at the documentation, it seems like this one delays the constant folding until runtime. I wonder if it might be worth doing it here instead of upon the first invocation. Not a big deal, but might be easier to handle with compilation.

@kshitij12345
Copy link
Collaborator Author

kshitij12345 commented Feb 9, 2023

I am not sure why lintrunner is failing on the files that this PR hasn't touched. Any idea? Recent master looks to be green.

@kshitij12345 kshitij12345 added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 9, 2023
@kshitij12345
Copy link
Collaborator Author

kshitij12345 commented Feb 9, 2023

@pytorchbot merge -f"lintrunner failing on unchanged files"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 9, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@kshitij12345
Copy link
Collaborator Author

kshitij12345 commented Feb 9, 2023

@pytorchbot revert -m "Broke lint runner" -c ignoredsignal

@kshitij12345 kshitij12345 reopened this Feb 9, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 9, 2023

@pytorchbot successfully started a revert job. Check the current status here.
Questions? Feedback? Please reach out to the PyTorch DevX Team

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 9, 2023

@kshitij12345 your PR has been successfully reverted.

pytorchmergebot added a commit that referenced this pull request Feb 9, 2023
@pytorchmergebot
Revert "[functorch] linearize (#94173)"
e0e4f1a 
This reverts commit b6b9e1e.

Reverted #94173 on behalf of https://github.com/kshitij12345 due to Broke lint runner
@kshitij12345 kshitij12345 mentioned this pull request Feb 9, 2023
Open
@kshitij12345
Copy link
Collaborator Author

kshitij12345 commented Feb 9, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 9, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@kshitij12345 kshitij12345 mentioned this pull request Sep 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Chillee Chillee Chillee approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: functorch Pertaining to torch.func or pytorch/functorch open source release notes: fx release notes category release notes: torch.func release notes category for torch.vmap or torch.func.* APIs Reverted triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add a linearize like jax.linearize

5 participants

@kshitij12345 @pytorchmergebot @Chillee @soulitzer @pytorchbot