[FSDP][state_dict] Fix incorrect valid_data_size for local_state_dict when some ranks have zero data. #94109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… when some ranks have zero data. When using `torch.chunks` to split the `flat_param`, some ranks may have zero data and `local_state_dict` does not handle the case correctly -- `local_state_dict` won't resize the local tensor to an empty one. This PR fixes the issue. Differential Revision: [D43004643](https://our.internmc.facebook.com/intern/diff/D43004643/) [ghstack-poisoned]
fegin
requested review from
H-Huang,
awgu,
kwen2501,
mrshenli,
rohan-varma,
wanchaol and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/94109
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 69491f1: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
…_state_dict when some ranks have zero data." When using `torch.chunks` to split the `flat_param`, some ranks may have zero data and `local_state_dict` does not handle the case correctly -- `local_state_dict` won't resize the local tensor to an empty one. This PR fixes the issue. Differential Revision: [D43004643](https://our.internmc.facebook.com/intern/diff/D43004643/) [ghstack-poisoned]
…_state_dict when some ranks have zero data." When using `torch.chunks` to split the `flat_param`, some ranks may have zero data and `local_state_dict` does not handle the case correctly -- `local_state_dict` won't resize the local tensor to an empty one. This PR fixes the issue. Differential Revision: [D43004643](https://our.internmc.facebook.com/intern/diff/D43004643/) [ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Feb 4, 2023
… when some ranks have zero data. Pull Request resolved: #94109 When using `torch.chunks` to split the `flat_param`, some ranks may have zero data and `local_state_dict` does not handle the case correctly -- `local_state_dict` won't resize the local tensor to an empty one. This PR fixes the issue. ghstack-source-id: 179327901 Differential Revision: [D43004643](https://our.internmc.facebook.com/intern/diff/D43004643/)
zhaojuanmao
approved these changes
Feb 4, 2023
…_state_dict when some ranks have zero data." When using `torch.chunks` to split the `flat_param`, some ranks may have zero data and `local_state_dict` does not handle the case correctly -- `local_state_dict` won't resize the local tensor to an empty one. This PR fixes the issue. Differential Revision: [D43004643](https://our.internmc.facebook.com/intern/diff/D43004643/) [ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Feb 6, 2023
… when some ranks have zero data. Pull Request resolved: #94109 When using `torch.chunks` to split the `flat_param`, some ranks may have zero data and `local_state_dict` does not handle the case correctly -- `local_state_dict` won't resize the local tensor to an empty one. This PR fixes the issue. ghstack-source-id: 179457801 Differential Revision: [D43004643](https://our.internmc.facebook.com/intern/diff/D43004643/)
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
When using
torch.chunksto split theflat_param, some ranks may have zero data andlocal_state_dictdoes not handle the case correctly --local_state_dictwon't resize the local tensor to an empty one. This PR fixes the issue.Differential Revision: D43004643