[dtensor] add split_with_sizes op #93957
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add the split_with_sizes op, sharing with split op impl [ghstack-poisoned]
wanchaol
requested review from
H-Huang,
awgu,
kwen2501,
mrshenli,
rohan-varma and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/93957
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit cc65ace: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
XilunWu
approved these changes
Feb 2, 2023
Contributor
XilunWu
left a comment
XilunWu
left a comment
There was a problem hiding this comment.
LGTM! Thx for putting the common logic into a function!
add the split_with_sizes op, sharing with split op impl [ghstack-poisoned]
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
add the split_with_sizes op, sharing with split op impl