Skip to content

Add BatchBucketizeOp in caffe2 #9385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
nateanl wants to merge 1 commit into from
Closed

Add BatchBucketizeOp in caffe2 #9385

nateanl wants to merge 1 commit into from

Conversation

@nateanl
Copy link
Member

@nateanl nateanl commented Jul 12, 2018

Summary: The operator transform dense features to sparse features by bucketizing. Only the feature in indices tensor will be transformed and output.

Differential Revision: D8820351

bddppq
bddppq reviewed Jul 12, 2018
View reviewed changes
caffe2/operators/batch_bucketize_op.cc Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/operators/batch_bucketize_op.cc Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

caffe2/operators/batch_bucketize_op.cc Outdated

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

This comment was marked as off-topic.

Sign in to view

bddppq
bddppq reviewed Jul 13, 2018
View reviewed changes
caffe2/operators/batch_bucketize_op.cc Outdated

This comment was marked as off-topic.

Sign in to view

bddppq
bddppq reviewed Jul 13, 2018
View reviewed changes
caffe2/operators/batch_bucketize_op.cc Outdated

This comment was marked as off-topic.

Sign in to view

bddppq
bddppq reviewed Jul 13, 2018
View reviewed changes
caffe2/python/operator_test/batch_bucketize_op_test.py Outdated

This comment was marked as off-topic.

Sign in to view

@nateanl @facebook-github-bot
Add BatchBucketizeOp in caffe2 (pytorch#9385)
d326b67 
Summary:
Pull Request resolved: pytorch#9385

The operator transform dense features to sparse features by bucketizing. Only the feature in indices tensor will be transformed and output.

Differential Revision: D8820351

fbshipit-source-id: 7b23187713a2d370df5c1f9e4990c480c29b8969
@bddppq bddppq self-requested a review July 13, 2018 20:31
bddppq
bddppq approved these changes Jul 13, 2018
View reviewed changes
Copy link
Contributor

@bddppq bddppq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

petrex pushed a commit to petrex/pytorch that referenced this pull request Jul 16, 2018
Merge remote-tracking branch 'upstream/master' into hipify_c2
986eeb7 
* upstream/master: (24 commits)
  Implement tensor weak references (pytorch#9363)
  Nuke TestCollectEnv (pytorch#9459)
  Add test case for segmentation fault fix in grad_fn (pytorch#9457)
  Add peephole optimization for type_as operators. (pytorch#9316)
  Fix out-of-range error for test_neg (pytorch#9431)
  add depthwise conv support for mkldnn (pytorch#8782)
  Refactor `_log_sum_exp` (pytorch#9173)
  Add ModuleDict and ParameterDict containers (pytorch#8463)
  Introduce SupervisedPtr, delete THAllocator and THCDeviceAllocator (pytorch#9358)
  Introducing IsInf (pytorch#9169)
  add device to CUDAEvent (pytorch#9415)
  Make localScalar error message more intuitive (pytorch#9443)
  Only accept continguous tensors in TopK for cuda (pytorch#9441)
  Add support for .norm() pytorch onnx export and ReduceL1/ReduceL2 caffe2 operators (pytorch#9299)
  Only view() rhs of index_put if we need to (pytorch#9424)
  Add BatchBucketizeOp in caffe2 (pytorch#9385)
  Implementation of Wngrad optimizer caffe2 python wrapper and unit test on least square regression (pytorch#9001)
  Implementation and operator test for Wngrad optimizer (pytorch#8999)
  Fix segmentation fault in grad_fn (pytorch#9292)
  update docs (pytorch#9423)
  ...
goldsborough pushed a commit to goldsborough/pytorch that referenced this pull request Jul 20, 2018
@nateanl @goldsborough
Add BatchBucketizeOp in caffe2 (pytorch#9385)
9923ad6 
Summary:
Pull Request resolved: pytorch#9385

The operator transform dense features to sparse features by bucketizing. Only the feature in indices tensor will be transformed and output.

Reviewed By: bddppq

Differential Revision: D8820351

fbshipit-source-id: a66cae546b870c6b2982ac20641f198334f2e853
jramseyer pushed a commit to jramseyer/pytorch that referenced this pull request Jul 30, 2018
@nateanl @jramseyer
Add BatchBucketizeOp in caffe2 (pytorch#9385)
7a232e2 
Summary:
Pull Request resolved: pytorch#9385

The operator transform dense features to sparse features by bucketizing. Only the feature in indices tensor will be transformed and output.

Reviewed By: bddppq

Differential Revision: D8820351

fbshipit-source-id: a66cae546b870c6b2982ac20641f198334f2e853
goodlux pushed a commit to goodlux/pytorch that referenced this pull request Aug 15, 2018
@nateanl
Add BatchBucketizeOp in caffe2 (pytorch#9385)
bce3c86 
Summary:
Pull Request resolved: pytorch#9385

The operator transform dense features to sparse features by bucketizing. Only the feature in indices tensor will be transformed and output.

Reviewed By: bddppq

Differential Revision: D8820351

fbshipit-source-id: a66cae546b870c6b2982ac20641f198334f2e853
@ezyang ezyang added the merged label Jun 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@amirshim amirshim amirshim left review comments

@bddppq bddppq bddppq approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nateanl @amirshim @bddppq @ezyang