Skip to content

[DTensor][fix] MultiThreadedTestCase misses _tls object and it won't reflect in CI #93832

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
XilunWu wants to merge 2 commits into from
Closed

[DTensor][fix] MultiThreadedTestCase misses _tls object and it won't reflect in CI #93832

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
74664cf
[DTensor][fix] MultiThreadedTestCase misses _tls object and it won't …
XilunWu Feb 1, 2023
ed8e4ae
Update on "[DTensor][fix] MultiThreadedTestCase misses _tls object an…
XilunWu Feb 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions torch/testing/_internal/common_distributed.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1025,6 +1025,7 @@ def _run(cls, test_name, rank, world_size):
# every thread have the same value. This would be relevant when we use op db tests, where it
# needs those states to be set i.e. using instantiate_device_type_tests()
# TODO: figure out a better way to do this
self._tls = threading.local()
self._tls.precision = TestCase._precision
self._tls.rel_tol = TestCase._rel_tol

Expand Down