Implement calling of c10 ops from c2 #9369
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
This is doing the same thing as #8809 but the PR was recreated due to ShipIt complications |
dzhulgakov
reviewed
Jul 12, 2018
caffe2/operators/c10_sigmoid_op.cc
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
caffe2/core/operator_c10wrapper.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
caffe2/core/operator_c10wrapper.h
Outdated
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
smessmer
force-pushed
the
export-D8814669
branch
from
b34956d to
5112991
Compare
smessmer
force-pushed
the
export-D8814669
branch
from
5112991 to
0996a3a
Compare
smessmer
force-pushed
the
export-D8814669
branch
from
0996a3a to
d378d38
Compare
smessmer
force-pushed
the
export-D8814669
branch
from
d378d38 to
aae62d7
Compare
smessmer
force-pushed
the
export-D8814669
branch
from
aae62d7 to
4fb5d20
Compare
smessmer
force-pushed
the
export-D8814669
branch
from
4fb5d20 to
453b1b8
Compare
smessmer
requested review from
Yangqing,
anderspapitto,
apaszke,
bddppq,
colesbury,
ebetica,
ezyang,
gchanan,
goldsborough,
houseroad,
jamesr66a,
pietern,
soumith,
teng-li and
zdevito
as code owners
smessmer
force-pushed
the
export-D8814669
branch
from
453b1b8 to
92364d0
Compare
smessmer
force-pushed
the
export-D8814669
branch
from
92364d0 to
66cf9e3
Compare
smessmer
force-pushed
the
export-D8814669
branch
from
66cf9e3 to
2068b23
Compare
smessmer
force-pushed
the
export-D8814669
branch
from
2068b23 to
6ed04b4
Compare
smessmer
force-pushed
the
export-D8814669
branch
from
6ed04b4 to
5dbb9ea
Compare
smessmer
force-pushed
the
export-D8814669
branch
from
5dbb9ea to
dcae9f6
Compare
smessmer
force-pushed
the
export-D8814669
branch
from
dcae9f6 to
88933f6
Compare
smessmer
force-pushed
the
export-D8814669
branch
from
88933f6 to
916685d
Compare
smessmer
force-pushed
the
export-D8814669
branch
from
916685d to
32a1e9b
Compare
Contributor
|
Can you add the test script to the actual repo so it gets run when we do OSS tests? |
Summary: Pull Request resolved: pytorch#9369 This adds the capability for caffe2 to call c10 operators and adds a dummy c10 sigmoid op as a proof of concept. I used this test script to make sure it works: from caffe2.python import workspace, model_helper import numpy as np data1 = np.random.rand(16, 100).astype(np.float32) workspace.FeedBlob("data1", data1) m = model_helper.ModelHelper(name="my net") sigmoid1 = m.net.C10Sigmoid_DontUseThisOpYet("data1", "sigmoid1") sigmoid2 = m.net.Sigmoid("data1", "sigmoid2") workspace.RunNetOnce(m.param_init_net) workspace.CreateNet(m.net) data1 = np.random.rand(16, 100).astype(np.float32) workspace.FeedBlob("data1", data1) workspace.RunNet(m.name, 1) print(workspace.FetchBlob("data1")) print(workspace.FetchBlob("sigmoid1")) print(workspace.FetchBlob("sigmoid2")) (and check that both sigmoid outputs are the same) Reviewed By: ezyang Differential Revision: D8814669 fbshipit-source-id: e289f0649d23dc9c2689c528fb9da9caf94eb6b5
smessmer
force-pushed
the
export-D8814669
branch
from
32a1e9b to
eaaad21
Compare
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Pull Request resolved: pytorch#9369 This adds the capability for caffe2 to call c10 operators and adds a dummy c10 sigmoid op as a proof of concept. I used this test script to make sure it works: from caffe2.python import workspace, model_helper import numpy as np data1 = np.random.rand(16, 100).astype(np.float32) workspace.FeedBlob("data1", data1) m = model_helper.ModelHelper(name="my net") sigmoid1 = m.net.C10Sigmoid_DontUseThisOpYet("data1", "sigmoid1") sigmoid2 = m.net.Sigmoid("data1", "sigmoid2") workspace.RunNetOnce(m.param_init_net) workspace.CreateNet(m.net) data1 = np.random.rand(16, 100).astype(np.float32) workspace.FeedBlob("data1", data1) workspace.RunNet(m.name, 1) print(workspace.FetchBlob("data1")) print(workspace.FetchBlob("sigmoid1")) print(workspace.FetchBlob("sigmoid2")) (and check that both sigmoid outputs are the same) Reviewed By: ezyang Differential Revision: D8814669 fbshipit-source-id: eeb0e7a854727f1617a3c592a662a7e5ae226f40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This adds the capability for caffe2 to call c10 operators and adds a dummy c10 sigmoid op as a proof of concept.
I used this test script to make sure it works:
(and check that both sigmoid outputs are the same)
Differential Revision: D8814669