Skip to content

[PT-D][TP] Fix the module registration in TP API #93412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fduwjj wants to merge 2 commits into from
Closed

[PT-D][TP] Fix the module registration in TP API #93412

fduwjj wants to merge 2 commits into from

Conversation

@fduwjj
Copy link
Contributor

@fduwjj fduwjj commented Feb 1, 2023 •
edited
Loading

fduwjj added a commit that referenced this pull request Feb 1, 2023
@fduwjj
[PT-D] Fix the module registration in TP API
819e29f 
ghstack-source-id: b86b58f
Pull Request resolved: #93412
@pytorch-bot
Copy link

pytorch-bot bot commented Feb 1, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/93412

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 17d7cb9:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@fduwjj fduwjj requested a review from wz337 February 1, 2023 00:24
@fduwjj fduwjj changed the title [PT-D] Fix the module registration in TP API [PT-D][TP] Fix the module registration in TP API Feb 1, 2023
@fduwjj fduwjj added module: dtensor distributed tensor tag release notes: distributed (dtensor) release notes category labels Feb 1, 2023
XilunWu
XilunWu approved these changes Feb 1, 2023
View reviewed changes
Copy link
Contributor

@XilunWu XilunWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Thx for fixing the nested case in registration and adding a test!

@fduwjj
Copy link
Contributor Author

fduwjj commented Feb 1, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Feb 1, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 1, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 1, 2023

Merge failed

Reason: 2 jobs have failed, first few of them are: trunk / win-vs2019-cuda11.6-py3 / test (default, 3, 5, windows.g5.4xlarge.nvidia.gpu), trunk / win-vs2019-cuda11.6-py3 / test (default, 4, 5, windows.g5.4xlarge.nvidia.gpu)

Details for Dev Infra team Raised by workflow job

@fduwjj
Copy link
Contributor Author

fduwjj commented Feb 1, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 1, 2023

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 1, 2023

Successfully rebased gh/fduwjj/67/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/93412)

pytorchmergebot pushed a commit that referenced this pull request Feb 1, 2023
@fduwjj
[PT-D] Fix the module registration in TP API
2a1f95f 
ghstack-source-id: 6ba4dc0
Pull Request resolved: #93412
@fduwjj
Copy link
Contributor Author

fduwjj commented Feb 1, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 1, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/fduwjj/67/head branch June 8, 2023 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@XilunWu XilunWu XilunWu approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@wanchaol wanchaol Awaiting requested review from wanchaol

@wz337 wz337 Awaiting requested review from wz337

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged module: dtensor distributed tensor tag release notes: distributed (dtensor) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@fduwjj @pytorchmergebot @XilunWu