[FSDP][optim_state_dict] Fix _is_named_optimizer when the state is empty
#93303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…empty Optimizer state is not eager initializaion -- only NamedOptimizer and KeyedOptimizer are. This PR makes it `_is_named_optimizer` work with regular optimizers. Differential Revision: [D42858589](https://our.internmc.facebook.com/intern/diff/D42858589/) [ghstack-poisoned]
fegin
requested review from
H-Huang,
awgu,
kwen2501,
mrshenli,
rohan-varma,
wanchaol and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/93303
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 7d37ddc: FLAKY - The following jobs failed but were likely due to flakiness present on master:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
…e state is empty" Optimizer state is not eager initializaion -- only NamedOptimizer and KeyedOptimizer are. This PR makes it `_is_named_optimizer` work with regular optimizers. Differential Revision: [D42858589](https://our.internmc.facebook.com/intern/diff/D42858589/) [ghstack-poisoned]
…e state is empty" Optimizer state is not eager initializaion -- only NamedOptimizer and KeyedOptimizer are. This PR makes it `_is_named_optimizer` work with regular optimizers. Differential Revision: [D42858589](https://our.internmc.facebook.com/intern/diff/D42858589/) [ghstack-poisoned]
…e state is empty" Optimizer state is not eager initializaion -- only NamedOptimizer and KeyedOptimizer are. This PR makes it `_is_named_optimizer` work with regular optimizers. Differential Revision: [D42858589](https://our.internmc.facebook.com/intern/diff/D42858589/) [ghstack-poisoned]
…e state is empty" Optimizer state is not eager initializaion -- only NamedOptimizer and KeyedOptimizer are. This PR makes it `_is_named_optimizer` work with regular optimizers. Differential Revision: [D42858589](https://our.internmc.facebook.com/intern/diff/D42858589/) [ghstack-poisoned]
…e state is empty" Optimizer state is not eager initializaion -- only NamedOptimizer and KeyedOptimizer are. This PR makes it `_is_named_optimizer` work with regular optimizers. Differential Revision: [D42858589](https://our.internmc.facebook.com/intern/diff/D42858589/) [ghstack-poisoned]
…e state is empty" Optimizer state is not eager initializaion -- only NamedOptimizer and KeyedOptimizer are. This PR makes it `_is_named_optimizer` work with regular optimizers. Differential Revision: [D42858589](https://our.internmc.facebook.com/intern/diff/D42858589/) [ghstack-poisoned]
fegin
added a commit
that referenced
this pull request
Jan 30, 2023
…empty Pull Request resolved: #93303 Optimizer state is not eager initializaion -- only NamedOptimizer and KeyedOptimizer are. This PR makes it `_is_named_optimizer` work with regular optimizers. ghstack-source-id: 178827735 Differential Revision: [D42858589](https://our.internmc.facebook.com/intern/diff/D42858589/)
Contributor
Author
|
@pytorchbot merge -f "The failing test is not related" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
_is_named_optimizerwhen the state is empty #93303Optimizer state is not eager initializaion -- only NamedOptimizer and KeyedOptimizer are. This PR makes it
_is_named_optimizerwork with regular optimizers.Differential Revision: D42858589