Improve DDPOptimizer by avoiding small preamble graph #93162
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This optimizes an edge case where some compute-only ops (e.g. add) could end up in an orphan graph at the input side due to the bucket for the next graph being full already. The fix is to fuse this graph (which is "empty" in parameter count) together with the adjoining "full" bucket. Note: i encountered this when trying to repro some suspected duplicate argument errors, but this is unrelated and I have not yet repro'd a duplicate arg issue. [ghstack-poisoned]
wconstab
requested review from
H-Huang,
awgu,
kwen2501,
mrshenli,
rohan-varma,
wanchaol and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/93162
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit 5391580: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
wconstab
changed the title
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 1 jobs have failed, first few of them are: inductor / cuda11.6-py3.10-gcc7-sm86 / test (inductor_distributed, 1, 1, linux.g5.12xlarge.nvidia.gpu) Details for Dev Infra teamRaised by workflow job |
This optimizes an edge case where some compute-only ops (e.g. add) could end up in an orphan graph at the input side due to the bucket for the next graph being full already. The fix is to fuse this graph (which is "empty" in parameter count) together with the adjoining "full" bucket. Note: i encountered this when trying to repro some suspected duplicate argument errors, but this is unrelated and I have not yet repro'd a duplicate arg issue. cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
This optimizes an edge case where some compute-only ops (e.g. add) could end up in an orphan graph at the input side due to the bucket for the next graph being full already. The fix is to fuse this graph (which is "empty" in parameter count) together with the adjoining "full" bucket. Note: i encountered this when trying to repro some suspected duplicate argument errors, but this is unrelated and I have not yet repro'd a duplicate arg issue. cc mlazos soumith voznesenskym yanboliang penguinwu anijain2305 EikanWang jgong5 Guobing-Chen chunyuan-w XiaobingSuper zhuhaozhe blzheng Xia-Weiwen wenzhe-nrv jiayisunx desertfire [ghstack-poisoned]
wconstab
added a commit
that referenced
this pull request
Jan 27, 2023
This optimizes an edge case where some compute-only ops (e.g. add) could end up in an orphan graph at the input side due to the bucket for the next graph being full already. The fix is to fuse this graph (which is "empty" in parameter count) together with the adjoining "full" bucket. Note: i encountered this when trying to repro some suspected duplicate argument errors, but this is unrelated and I have not yet repro'd a duplicate arg issue. ghstack-source-id: 6f4baa0 Pull Request resolved: #93162
Contributor
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 1 mandatory check(s) failed (Rule Dig deeper by viewing the failures on hud Details for Dev Infra teamRaised by workflow job |
Contributor
Author
|
@pytorchbot merge -f "flaky CI failure" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
This optimizes an edge case where some compute-only ops (e.g. add)
could end up in an orphan graph at the input side due to the bucket
for the next graph being full already. The fix is to fuse this
graph (which is "empty" in parameter count) together with the adjoining
"full" bucket.
Note: i encountered this when trying to repro some suspected duplicate
argument errors, but this is unrelated and I have not yet repro'd
a duplicate arg issue.
cc @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire