Skip to content

Set min supported Python version to 3.8 #93155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
malfet wants to merge 4 commits into from
Closed

Set min supported Python version to 3.8 #93155

malfet wants to merge 4 commits into from

Conversation

@malfet
Copy link
Contributor

@malfet malfet commented Jan 27, 2023 •
edited
Loading

Also, grep for if sys.version_info .cond. (3, 8) and replaces them with appropriate action.

This is a last in a series of PRs that moved CI/CD away from testing PyTorch behavior against Python-3.7.

Fixes #80513

cc @albanD @mlazos @soumith @voznesenskym @yanboliang @penguinwu @anijain2305 @EikanWang @jgong5 @Guobing-Chen @chunyuan-w @XiaobingSuper @zhuhaozhe @blzheng @Xia-Weiwen @wenzhe-nrv @jiayisunx @desertfire

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 27, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/93155

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit cc58bae:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jan 27, 2023
@malfet malfet added module: python frontend For issues relating to PyTorch's Python frontend and removed topic: not user facing topic category labels Jan 27, 2023
@pytorch-bot pytorch-bot bot added the topic: not user facing topic category label Jan 27, 2023
ZainRizvi
ZainRizvi requested changes Jan 27, 2023
View reviewed changes
Copy link
Contributor

@ZainRizvi ZainRizvi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And the CI validates that your check is working :)

https://github.com/pytorch/pytorch/actions/runs/4026325254/jobs/6920691212 fails with:
You are using Python 3.7.15. Python >=3.8.0 is required.

@huydhn
Copy link
Contributor

huydhn commented Jan 27, 2023

For the context, here is the PR I submitted to XLA pytorch/xla#4489

@malfet malfet force-pushed the malfet/update-min-req-to-3.8 branch from 901d41d to 508244c Compare January 28, 2023 03:42
@malfet malfet requested a review from a team as a code owner January 28, 2023 04:26
@malfet malfet added topic: bc breaking topic category ciflow/trunk Trigger trunk jobs on your pull request and removed topic: not user facing topic category labels Jan 28, 2023
@malfet malfet force-pushed the malfet/update-min-req-to-3.8 branch from 89db168 to 319d463 Compare January 28, 2023 17:11
@pytorch-bot pytorch-bot bot added the release notes: jit release notes category label Jan 28, 2023
@malfet
Copy link
Contributor Author

malfet commented Jan 28, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 28, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 28, 2023

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-libtorch-pre-cxx11 / libtorch-cpu-shared-with-deps-pre-cxx11-build / build

Details for Dev Infra team Raised by workflow job

@malfet
Copy link
Contributor Author

malfet commented Jan 29, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 29, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 29, 2023

Merge failed

Reason: 1 jobs have failed, first few of them are: linux-binary-libtorch-pre-cxx11 / libtorch-cpu-shared-with-deps-pre-cxx11-build / build

Details for Dev Infra team Raised by workflow job

@malfet
Copy link
Contributor Author

malfet commented Jan 29, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 29, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 29, 2023

The merge job was canceled. If you believe this is a mistake,then you can re trigger it through pytorch-bot.

@malfet malfet changed the title Update min supported version to 3.8 Update min supported python version to 3.8 Jan 29, 2023
@malfet malfet changed the title Update min supported python version to 3.8 Set min supported Python version to 3.8 Jan 29, 2023
@malfet
Copy link
Contributor Author

malfet commented Jan 29, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 29, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@adamjstewart adamjstewart mentioned this pull request Jan 29, 2023
Merged
@Skylion007
Copy link
Collaborator

Skylion007 commented Jan 29, 2023

@malfet Did you intent to change the LibKineto submodule?

@malfet
Copy link
Contributor Author

malfet commented Jan 29, 2023

@Skylion007 no, it was not intentional. Let me revert and reland without the kineto change

malfet added a commit that referenced this pull request Jan 29, 2023
@malfet
Revert accidental change to libkineto version
ca51046 
Introduced by #93155
@malfet malfet mentioned this pull request Jan 29, 2023
Closed
@malfet
Copy link
Contributor Author

malfet commented Jan 29, 2023

@Skylion007 actually, do you mind giving a stamp on #93237

pytorchmergebot pushed a commit that referenced this pull request Jan 29, 2023
@malfet @pytorchmergebot
Revert accidental change to libkineto version (#93237)
239afa0 
Introduced by #93155

Pull Request resolved: #93237
Approved by: https://github.com/Skylion007
weiwangmeta added a commit to pytorch/audio that referenced this pull request Jan 30, 2023
@weiwangmeta
Drop python 3.7 support
5ab6af7 
pytorch/pytorch#93155 Core has dropped python3.7
@weiwangmeta weiwangmeta mentioned this pull request Jan 30, 2023
Closed
@carmocca carmocca mentioned this pull request Jan 31, 2023
Closed
weiwangmeta added a commit to pytorch/audio that referenced this pull request Jan 31, 2023
@weiwangmeta
Drop python 3.7 support
4d20be2 
pytorch/pytorch#93155 Core has dropped python3.7
weiwangmeta added a commit to pytorch/audio that referenced this pull request Jan 31, 2023
@weiwangmeta
Drop python 3.7 support
e5b731f 
pytorch/pytorch#93155 Core has dropped python3.7
facebook-github-bot pushed a commit to pytorch/audio that referenced this pull request Feb 1, 2023
@weiwangmeta @facebook-github-bot
Drop python 3.7 support (#3020)
60af60a 
Summary:
pytorch/pytorch#93155 Core has dropped python3.7

Pull Request resolved: #3020

Reviewed By: mthrok

Differential Revision: D42902346

Pulled By: weiwangmeta

fbshipit-source-id: 07ab1aff0e128c5960d87e5fa29e341310dea388
@AzulGarza AzulGarza mentioned this pull request Apr 5, 2023
Closed
@malfet malfet deleted the malfet/update-min-req-to-3.8 branch January 20, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ZainRizvi ZainRizvi ZainRizvi requested changes

@huydhn huydhn huydhn approved these changes

Assignees

No one assigned

Labels

ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request Merged module: dynamo module: python frontend For issues relating to PyTorch's Python frontend release notes: jit release notes category topic: bc breaking topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Drop Python 3.7 support (following NEP 29)

6 participants

@malfet @huydhn @pytorchmergebot @Skylion007 @ZainRizvi