Skip to content

[PT-D][Checkpoint] Turn on all default planner flags #92933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wz337 wants to merge 5 commits into from
Closed

[PT-D][Checkpoint] Turn on all default planner flags #92933

wz337 wants to merge 5 commits into from

Conversation

@wz337
Copy link
Contributor

@wz337 wz337 commented Jan 24, 2023

Fixes #92823

@pytorch-bot pytorch-bot bot added the release notes: distributed (fsdp) release notes category label Jan 24, 2023
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 24, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92933

Note: Links to docs will display an error until the docs builds have been completed.

❌ 8 Failures

As of commit cdbb246:

NEW FAILURES - The following jobs have failed:

BROKEN TRUNK - The following jobs failed but were present on the merge base 811e95a:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@wz337 wz337 requested a review from kumpera January 24, 2023 23:50
@wz337 wz337 marked this pull request as ready for review January 24, 2023 23:52
kumpera
kumpera approved these changes Jan 24, 2023
View reviewed changes
Copy link
Contributor

@kumpera kumpera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

@wz337
Copy link
Contributor Author

wz337 commented Jan 25, 2023

@pytorchmergebot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 25, 2023

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 25, 2023

Successfully rebased default_planner_flags onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout default_planner_flags && git pull --rebase)

@wz337
Copy link
Contributor Author

wz337 commented Jan 25, 2023

@pytorchmergebot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 25, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 25, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 25, 2023

Merge failed

Reason: 2 mandatory check(s) failed (Rule Distributed). The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@kumpera
Copy link
Contributor

kumpera commented Feb 7, 2023

@wz337 a lot of DCP tests only run during merging and not CI testing since they require muiltiple gpus.

@wz337
Copy link
Contributor Author

wz337 commented Feb 8, 2023

@pytorchmergebot merge -f "unrelated xla, functorch, dynamo, crossref test failures"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 8, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

@wanchaol wanchaol Awaiting requested review from wanchaol

1 more reviewer

@kumpera kumpera kumpera approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (fsdp) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[PT-D][Checkpoint] Fix load_sharded_optimizer_state_dict() when default flatten_sharded_tensors to True

3 participants

@wz337 @pytorchmergebot @kumpera