[PT-D][Checkpoint]rename init() #92829
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92829
Note: Links to docs will display an error until the docs builds have been completed. ⏳ No Failures, 1 PendingAs of commit 8b1867b: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
wz337
requested review from
H-Huang,
awgu,
kwen2501,
mrshenli,
rohan-varma,
wanchaol and
zhaojuanmao
as code owners
kumpera
approved these changes
Jan 23, 2023
Contributor
kumpera
left a comment
kumpera
left a comment
There was a problem hiding this comment.
LGTM, should we do the same with storage layer?
Contributor
Author
Ye. Totally. Was having the same thoughts. Will do it in a separate PR then. |
Contributor
Author
|
@pytorchmergebot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
wz337
added a commit
to pytorch/PiPPy
that referenced
this pull request
Jan 26, 2023
Fix broken CI in pg_planner: ``` spmd/checkpoint/pg_planner.py:61:9: error: "init" undefined in superclass [misc] spmd/checkpoint/pg_planner.py:81:9: error: "init" undefined in superclass [misc] ``` This is changed due to pytorch/pytorch#92829.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #90346
Rename init() method in planner to be set_up_planner() to avoid confusion between init() and init().