Skip to content

[optim][sgd] default to foreach when CUDA + differentiable=False #92730

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
janeyx99 wants to merge 7 commits into from
Closed

[optim][sgd] default to foreach when CUDA + differentiable=False #92730

janeyx99 wants to merge 7 commits into from

Conversation

@janeyx99
Copy link
Contributor

@janeyx99 janeyx99 commented Jan 20, 2023 •
edited
Loading

@janeyx99 janeyx99 requested a review from albanD as a code owner January 20, 2023 23:29
@janeyx99 janeyx99 mentioned this pull request Jan 20, 2023
Closed
@pytorch-bot pytorch-bot bot added the release notes: nn release notes category label Jan 20, 2023
@janeyx99 janeyx99 mentioned this pull request Jan 20, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 20, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92730

Note: Links to docs will display an error until the docs builds have been completed.

❌ 1 Failures, 1 Pending

As of commit 14453d7:

NEW FAILURES - The following jobs have failed:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

This was referenced Jan 20, 2023
Closed
Closed
Closed
Closed
janeyx99 added a commit that referenced this pull request Jan 20, 2023
@janeyx99
[optim][sgd] default to foreach when CUDA + differentiable=False
7c2260f 
ghstack-source-id: 4de9593
Pull Request resolved: #92730
@janeyx99 janeyx99 added the topic: bc breaking topic category label Jan 20, 2023
janeyx99 added a commit that referenced this pull request Jan 23, 2023
@janeyx99
[optim][sgd] default to foreach when CUDA + differentiable=False
190ed20 
ghstack-source-id: b2f8c18
Pull Request resolved: #92730
albanD
albanD reviewed Jan 23, 2023
View reviewed changes
albanD
albanD approved these changes Jan 24, 2023
View reviewed changes
Copy link
Collaborator

@albanD albanD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good!

@janeyx99
Copy link
Contributor Author

janeyx99 commented Jan 24, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 24, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 24, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 24, 2023

Merge failed

Reason: 2 mandatory check(s) failed (Rule superuser). The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@janeyx99 janeyx99 mentioned this pull request Jan 24, 2023
Closed
janeyx99 added a commit that referenced this pull request Jan 24, 2023
@janeyx99
[optim][sgd] default to foreach when CUDA + differentiable=False
3b709e3 
ghstack-source-id: cded890
Pull Request resolved: #92730
janeyx99 added a commit that referenced this pull request Jan 25, 2023
@janeyx99
[optim][sgd] default to foreach when CUDA + differentiable=False
2eecf8d 
ghstack-source-id: c040291
Pull Request resolved: #92730
@janeyx99
Copy link
Contributor Author

janeyx99 commented Jan 25, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 25, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 25, 2023

Merge failed

Reason: 1 mandatory check(s) failed (Rule superuser). The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

janeyx99 added a commit that referenced this pull request Jan 25, 2023
@janeyx99
[optim][sgd] default to foreach when CUDA + differentiable=False
87a8afa 
ghstack-source-id: f09e49d
Pull Request resolved: #92730
@janeyx99
Copy link
Contributor Author

janeyx99 commented Jan 25, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 25, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 25, 2023

Merge failed

Reason: 1 mandatory check(s) failed (Rule superuser). The first few are:

Dig deeper by viewing the failures on hud

Details for Dev Infra team Raised by workflow job

@janeyx99
Copy link
Contributor Author

janeyx99 commented Jan 26, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 26, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/janeyx99/21/head branch June 8, 2023 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@albanD albanD albanD approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: nn release notes category topic: bc breaking topic category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@janeyx99 @pytorchmergebot @albanD