Skip to content

[PT-D] Enable Meta Tensor Support for DTensor #92652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
fduwjj wants to merge 9 commits into from
Closed

[PT-D] Enable Meta Tensor Support for DTensor #92652

fduwjj wants to merge 9 commits into from

Conversation

@fduwjj
Copy link
Contributor

@fduwjj fduwjj commented Jan 19, 2023 •
edited by pytorchmergebot
Loading

@fduwjj fduwjj mentioned this pull request Jan 19, 2023
Closed
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 19, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92652

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 2 Pending

As of commit 04fa5ae:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@fduwjj fduwjj added the release notes: distributed (dtensor) release notes category label Jan 19, 2023
@fduwjj
Copy link
Contributor Author

fduwjj commented Jan 19, 2023

For discussion and feedback gathering. Will iterate on comments.

fduwjj added a commit that referenced this pull request Jan 20, 2023
@fduwjj
[PT-D] Enable Meta Tensor Support for DTensor
78424de 
ghstack-source-id: 52d643f
Pull Request resolved: #92652
@fduwjj fduwjj mentioned this pull request Jan 20, 2023
Closed
fduwjj added a commit that referenced this pull request Jan 20, 2023
@fduwjj
[PT-D] Enable Meta Tensor Support for DTensor
3863124 
ghstack-source-id: 894063e
Pull Request resolved: #92652
wanchaol
wanchaol reviewed Jan 20, 2023
View reviewed changes
Copy link
Collaborator

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I think we probably need to check the materialization behavior to make sure it works properly, also add a e2e test.

fduwjj added a commit that referenced this pull request Jan 20, 2023
@fduwjj
[PT-D] Enable Meta Tensor Support for DTensor
de1ad0a 
ghstack-source-id: 7b2b65c
Pull Request resolved: #92652
fduwjj added a commit that referenced this pull request Jan 24, 2023
@fduwjj
[PT-D] Enable Meta Tensor Support for DTensor
90c8efe 
ghstack-source-id: dddf095
Pull Request resolved: #92652
@fduwjj fduwjj requested a review from wanchaol January 24, 2023 23:54
XilunWu
XilunWu approved these changes Jan 25, 2023
View reviewed changes
Copy link
Contributor

@XilunWu XilunWu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Left some n00b questions.

@fduwjj
Copy link
Contributor Author

fduwjj commented Jan 25, 2023

@pytorchbot merge

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 25, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 25, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

wanchaol
wanchaol requested changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The module test seems not comparing against the right ones? Please see inlined comment, requesting change first

@fduwjj fduwjj requested a review from wanchaol January 25, 2023 23:16
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 25, 2023

Merge failed

Reason: New commits were pushed while merging. Please rerun the merge command.

Details for Dev Infra team Raised by workflow job

wanchaol
wanchaol approved these changes Jan 25, 2023
View reviewed changes
Copy link
Collaborator

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for addressing the comments!

@fduwjj
Copy link
Contributor Author

fduwjj commented Jan 26, 2023

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 26, 2023

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 26, 2023

Successfully rebased gh/fduwjj/63/orig onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via ghstack checkout https://github.com/pytorch/pytorch/pull/92652)

pytorchmergebot pushed a commit that referenced this pull request Jan 26, 2023
@fduwjj
[PT-D] Enable Meta Tensor Support for DTensor
8c496dd 
ghstack-source-id: 1f0817b
Pull Request resolved: #92652
@fduwjj
Copy link
Contributor Author

fduwjj commented Jan 26, 2023

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 26, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@facebook-github-bot facebook-github-bot deleted the gh/fduwjj/63/head branch June 8, 2023 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wanchaol wanchaol wanchaol approved these changes

@XilunWu XilunWu XilunWu approved these changes

@mrshenli mrshenli Awaiting requested review from mrshenli

@zhaojuanmao zhaojuanmao Awaiting requested review from zhaojuanmao

@rohan-varma rohan-varma Awaiting requested review from rohan-varma

@H-Huang H-Huang Awaiting requested review from H-Huang

@awgu awgu Awaiting requested review from awgu

@kwen2501 kwen2501 Awaiting requested review from kwen2501

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request Merged release notes: distributed (dtensor) release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@fduwjj @pytorchmergebot @wanchaol @XilunWu