[FSDP][1/N] Split fully_shard unit tests
#92296
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92296
Note: Links to docs will display an error until the docs builds have been completed. ❌ 4 FailuresAs of commit c5f0d89: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jan 17, 2023
awgu
pushed a commit
to awgu/pytorch
that referenced
this pull request
Jan 17, 2023
ghstack-source-id: 535f26d Pull Request resolved: pytorch#92296
awgu
requested review from
H-Huang,
kwen2501,
mrshenli,
rohan-varma,
wanchaol and
zhaojuanmao
as code owners
This PR splits `test_fully_shard.py` into `fully_shard/test_fully_shard<...>.py`. This should help improve readability and avoid some future rebase conflicts. The only other real change is resolving a `TODO` for using `run_subtests` in the model checkpointing unit tests. [ghstack-poisoned]
This PR splits `test_fully_shard.py` into `fully_shard/test_fully_shard<...>.py`. This should help improve readability and avoid some future rebase conflicts. The only other real change is resolving a `TODO` for using `run_subtests` in the model checkpointing unit tests. [ghstack-poisoned]
This PR splits `test_fully_shard.py` into `fully_shard/test_fully_shard<...>.py`. This should help improve readability and avoid some future rebase conflicts. The only other real change is resolving a `TODO` for using `run_subtests` in the model checkpointing unit tests. [ghstack-poisoned]
awgu
commented
Jan 19, 2023
| E2E test of save + load with rank0_only + CPU offload for TransformerWithSharedParams | ||
| on the composable path. | ||
| """ | ||
| self.run_subtests( |
Collaborator
Author
There was a problem hiding this comment.
This is the only real change, where I knocked out a to-do to use run_subtests.
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Collaborator
Merge failedReason: 2 mandatory check(s) failed (Rule
Dig deeper by viewing the failures on hud Details for Dev Infra teamRaised by workflow job |
Collaborator
Author
|
Failures look unrelated: linux-bionic-py3_7-clang8-xla / test (xla, 1, 1, linux.4xlarge) linux-focal-py3.7-gcc7 / test (default, 1, 2, linux.2xlarge) linux-focal-rocm5.3-py3.8 / test (default, 1, 2, linux.rocm.gpu) |
Collaborator
Author
|
@pytorchbot merge -f "unrelated failures" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
This was referenced Jan 20, 2023
awgu
pushed a commit
to awgu/pytorch
that referenced
this pull request
Jan 23, 2023
ghstack-source-id: 4224de3 Pull Request resolved: pytorch#92296
This was referenced Jan 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
summon_full_paramsunit tests #92298 [FSDP][3/N] Refactorsummon_full_paramsunit tests_summon_full_params->_unshard_params#92297 [FSDP][2/N]_summon_full_params->_unshard_paramsfully_shardunit tests #92296 [FSDP][1/N] Splitfully_shardunit testsThis PR splits
test_fully_shard.pyintofully_shard/test_fully_shard<...>.py. This should help improve readability and avoid some future rebase conflicts.The only other real change is resolving a
TODOfor usingrun_subtestsin the model checkpointing unit tests.