Skip to content

Reduce some ambiguity in Tensor #92266

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
yinghai wants to merge 1 commit into from
Closed

Reduce some ambiguity in Tensor #92266

yinghai wants to merge 1 commit into from

Conversation

@yinghai
Copy link
Contributor

@yinghai yinghai commented Jan 16, 2023

Summary:
A lot of other libraries have their own xyz::Tensor data structure. Under some rare cases, when they interop with torch, there will be compilation error such as

torch/csrc/api/include/torch/data/samplers/random.h(49): error: "Tensor" is ambiguous

Making some of the Tensor namespace clear will resolve this.

Test Plan: CI

Differential Revision: D42538675

@pytorch-bot
Copy link

pytorch-bot bot commented Jan 16, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92266

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 2 Pending

As of commit 961ec6f:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 16, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: yinghai / name: Yinghai Lu (d1a23ef91b3fc4c3efc7bf88eb23c1144fb75c0d)

@pytorch-bot pytorch-bot bot added the release notes: cpp release notes category label Jan 16, 2023
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 16, 2023

This pull request was exported from Phabricator. Differential Revision: D42538675

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 17, 2023

This pull request was exported from Phabricator. Differential Revision: D42538675

@yinghai
Copy link
Contributor Author

yinghai commented Jan 17, 2023

/easycla

2 similar comments
@malfet
Copy link
Contributor

malfet commented Jan 17, 2023

/easycla

@yinghai
Copy link
Contributor Author

yinghai commented Jan 17, 2023

/easycla

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 17, 2023

This pull request was exported from Phabricator. Differential Revision: D42538675

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 17, 2023

This pull request was exported from Phabricator. Differential Revision: D42538675

@facebook-github-bot
Reduce some ambiguity in Tensor (pytorch#92266)
961ec6f 
Summary:
Pull Request resolved: pytorch#92266

A lot of other libraries have their own `xyz::Tensor` data structure. Under some rare cases, when they interop with torch, there will be compilation error such as
```
torch/csrc/api/include/torch/data/samplers/random.h(49): error: "Tensor" is ambiguous
```
Making some of the `Tensor` namespace clear will resolve this.

 ignore-github-export-checks

Test Plan: CI

Reviewed By: malfet

Differential Revision: D42538675

fbshipit-source-id: 3bb47ad0d8e1d510f9e5d9a31b48ac3a2e257f9c
@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 18, 2023

This pull request was exported from Phabricator. Differential Revision: D42538675

@facebook-github-bot
Copy link
Contributor

facebook-github-bot commented Jan 18, 2023

@pytorchbot merge

(Initiating merge automatically since Phabricator Diff has merged)

@pytorch-bot pytorch-bot bot added the ciflow/trunk Trigger trunk jobs on your pull request label Jan 18, 2023
@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Jan 18, 2023

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

@malfet malfet malfet approved these changes

Assignees

No one assigned

Labels

ciflow/trunk Trigger trunk jobs on your pull request fb-exported Merged release notes: cpp release notes category

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yinghai @facebook-github-bot @malfet @pytorchmergebot @Skylion007