NumPy Scalar to PyTorch Scalar #9225
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishwakftw
requested review from
apaszke,
colesbury,
ezyang,
gchanan,
soumith and
zdevito
as code owners
li-roy
reviewed
Jul 7, 2018
torch/csrc/utils/tensor_new.cpp
Outdated
| if (PyArray_Check(obj)) { | ||
| auto array = (PyArrayObject*)obj; | ||
| return numpy_dtype_to_aten(PyArray_TYPE(array)); | ||
| } else if (PyArray_CheckScalar(obj)) { |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
li-roy
approved these changes
Jul 9, 2018
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@li-roy has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
colesbury
reviewed
Jul 9, 2018
torch/csrc/utils/tensor_new.cpp
Outdated
| return numpy_dtype_to_aten(PyArray_TYPE(array)); | ||
| } | ||
| if (PyArray_CheckScalar(obj)) { | ||
| auto array = (PyArrayObject*)(PyArray_FromScalar(obj, NULL)); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
Contributor
Author
|
Is this good to go? Sorry about the reminder. |
Contributor
facebook-github-bot
left a comment
facebook-github-bot
left a comment
There was a problem hiding this comment.
@ezyang has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
Contributor
|
No worries, reminders appreciated |
Contributor
Author
|
Is this good to go? |
Contributor
jramseyer
pushed a commit
to jramseyer/pytorch
that referenced
this pull request
Jul 31, 2018
Summary: Fixes pytorch#4985 . Pull Request resolved: pytorch#9225 Differential Revision: D8769317 Pulled By: ezyang fbshipit-source-id: eeaeaf0749c9dc9e372634da68b4bd23e6e3ad28
goodlux
pushed a commit
to goodlux/pytorch
that referenced
this pull request
Aug 15, 2018
Summary: Fixes pytorch#4985 . Pull Request resolved: pytorch#9225 Differential Revision: D8769317 Pulled By: ezyang fbshipit-source-id: eeaeaf0749c9dc9e372634da68b4bd23e6e3ad28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4985 .