[dtensor] enable op db tests by using multithreaded test case #92198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
wanchaol
requested review from
a team,
H-Huang,
awgu,
kwen2501,
mrshenli,
rohan-varma and
zhaojuanmao
as code owners
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92198
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a27147d: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
…ase" [ghstack-poisoned]
XilunWu
approved these changes
Jan 14, 2023
Contributor
XilunWu
left a comment
XilunWu
left a comment
There was a problem hiding this comment.
good to see that op db tests are now enabled!! Is there a way to see how much time more spent on CI now?
…ase" [ghstack-poisoned]
…ase" Time comparison between using MultithreadedTestCase and MultiProcessTestCase on op db tests is amazing! using MultiThreadTestCase on a AWS dev node: ``` time pytest test/distributed/_tensor/test_dtensor_ops.py ============= 175 passed, 42 skipped, 397 xfailed in 80.30s (0:01:20) ======= real 1m22.330s user 1m38.782s sys 0m18.762s ``` MultiProcessTestCase spends from 40mins to more than 1h, even if using pytest parallel testing tools. [ghstack-poisoned]
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Author
updated in the summary. |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Contributor
|
The speedup of testing is quite impressive!! Congrats! |
wanchaol
added a commit
to pytorch/PiPPy
that referenced
this pull request
Jan 17, 2023
Delete this test as it's now enabled in PyTorch directly after pytorch/pytorch#92198 [ghstack-poisoned]
wanchaol
added a commit
to pytorch/PiPPy
that referenced
this pull request
Jan 17, 2023
Delete this test as it's now enabled in PyTorch directly after pytorch/pytorch#92198 ghstack-source-id: 3a58d5b Pull Request resolved: #722
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Time comparison between using MultithreadedTestCase and MultiProcessTestCase on op db tests is amazing!
using MultiThreadTestCase on a AWS dev node:
MultiProcessTestCase spends from 40mins to more than 1h, even if using pytest parallel testing tools.