Deprecate .mT,.T,.mH,.H on 0D tensors #92143
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As discussed with @ngimel, this is not only not documented, but it's also an unnecessary edge case. See #90463 (comment) [ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92143
Note: Links to docs will display an error until the docs builds have been completed. ❌ 1 FailuresAs of commit ae0e89a: NEW FAILURES - The following jobs have failed:
This comment was automatically generated by Dr. CI and updates every 15 minutes. |
lezcano
changed the title
As discussed with ngimel, this is not only not documented, but also an unnecessary edge case. See #90463 (comment) [ghstack-poisoned]
lezcano
added a commit
that referenced
this pull request
Jan 13, 2023
As discussed with ngimel, this is not only not documented, but it's also an unnecessary edge case. See #90463 (comment) ghstack-source-id: ae0ae52 Pull Request resolved: #92143
As discussed with ngimel, this is not only not documented, but also an unnecessary edge case. See #90463 (comment) [ghstack-poisoned]
lezcano
added a commit
that referenced
this pull request
Jan 15, 2023
As discussed with ngimel, this is not only not documented, but it's also an unnecessary edge case. See #90463 (comment) ghstack-source-id: 36eb8d4 Pull Request resolved: #92143
lezcano
changed the title
As discussed with ngimel, this is not only not documented, but also an unnecessary edge case. See #90463 (comment) [ghstack-poisoned]
lezcano
added a commit
that referenced
this pull request
Jan 15, 2023
As discussed with ngimel, this is not only not documented, but it's also an unnecessary edge case. See #90463 (comment) ghstack-source-id: b4e85ca Pull Request resolved: #92143
ngimel
approved these changes
Jan 17, 2023
Collaborator
Author
|
@pytorchbot merge -f "unrelated errors" |
Collaborator
Merge startedYour change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
As discussed with @ngimel, this is not only not documented,
but also an unnecessary edge case. See #90463 (comment)