Skip to content

Add MPS support for aten::remainder.Tensor_out #92139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jinsu35 wants to merge 2 commits into from
Closed

Add MPS support for aten::remainder.Tensor_out #92139

jinsu35 wants to merge 2 commits into from

Conversation

@jinsu35
Copy link
Contributor

@jinsu35 jinsu35 commented Jan 13, 2023

Fixes #86806

@jinsu35 jinsu35 requested a review from kulinseth as a code owner January 13, 2023 07:03
@pytorch-bot
Copy link

pytorch-bot bot commented Jan 13, 2023 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92139

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit b68244f:
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/mps Run MPS tests (subset of trunk) release notes: mps Release notes category labels Jan 13, 2023
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Jan 13, 2023 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@jinsu35 jinsu35 mentioned this pull request Jan 13, 2023
Closed
@janeyx99 janeyx99 added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 13, 2023
@gpomeranz
Copy link

gpomeranz commented Jan 26, 2023

Any chance to merge this branch? I've tested the changes and was able to complete a build with these changes.

@rinat-akhmetov
Copy link

rinat-akhmetov commented Jan 27, 2023

@kulinseth, is there a way to progress the Pull Request?
All of the checks have been completed successfully apart from one, and I have attached a screenshot of the error message for your convenience.
Could you please provide any additional details about the PR that may be required beyond restarting the pipeline?
image

@25benjaminli
Copy link

25benjaminli commented Feb 7, 2023

Hi, will this be merged soon?

@DenisVieriu97
Copy link
Collaborator

DenisVieriu97 commented Feb 9, 2023

@pytorchbot rebase

DenisVieriu97
DenisVieriu97 approved these changes Feb 9, 2023
View reviewed changes
Copy link
Collaborator

@DenisVieriu97 DenisVieriu97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jinsu35 - change looks good. Could you please merge it in?

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 9, 2023

@pytorchbot successfully started a rebase job. Check the current status here

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 9, 2023

Successfully rebased fix-issue-86806 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout fix-issue-86806 && git pull --rebase)

@kulinseth
Copy link
Collaborator

kulinseth commented Feb 9, 2023

@pytorchbot merge -f "MPS tests are green"

@pytorchmergebot
Copy link
Collaborator

pytorchmergebot commented Feb 9, 2023

Merge started

Your change will be merged immediately since you used the force (-f) flag, bypassing any CI checks (ETA: 1-5 minutes).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kulinseth kulinseth kulinseth approved these changes

@DenisVieriu97 DenisVieriu97 DenisVieriu97 approved these changes

Assignees

No one assigned

Labels

ciflow/mps Run MPS tests (subset of trunk) Merged open source release notes: mps Release notes category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[MPS] Add support for aten::remainder.Tensor_out for MPS backend

9 participants

@jinsu35 @gpomeranz @rinat-akhmetov @25benjaminli @DenisVieriu97 @pytorchmergebot @kulinseth @pytorchbot @janeyx99