[FSDP][BE] Improve device_id + CPU offload test
#92031
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92031
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 8b06f89: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This was referenced Jan 11, 2023
Closes #83054. [ghstack-poisoned]
Closes #83054. The new version of the test ensures that the parent FSDP instance has managed parameters to trigger the `module.to(device_from_device_id)` call, which moves the child FSDP instance's managed parameters (and hence must be hackily moved back). [ghstack-poisoned]
awgu
requested review from
H-Huang,
kwen2501,
mrshenli,
rohan-varma,
wanchaol and
zhaojuanmao
as code owners
zhaojuanmao
approved these changes
Jan 12, 2023
Closes #83054. The new version of the test ensures that the parent FSDP instance has managed parameters to trigger the `module.to(device_from_device_id)` call, which moves the child FSDP instance's managed parameters (and hence must be hackily moved back). [ghstack-poisoned]
Closes #83054. The new version of the test ensures that the parent FSDP instance has managed parameters to trigger the `module.to(device_from_device_id)` call, which moves the child FSDP instance's managed parameters (and hence must be hackily moved back). [ghstack-poisoned]
rohan-varma
approved these changes
Jan 13, 2023
Contributor
rohan-varma
left a comment
rohan-varma
left a comment
There was a problem hiding this comment.
LGTM, thanks for enhancing the test!
Closes #83054. The new version of the test ensures that the parent FSDP instance has managed parameters to trigger the `module.to(device_from_device_id)` call, which moves the child FSDP instance's managed parameters (and hence must be hackily moved back). [ghstack-poisoned]
Collaborator
Author
|
@pytorchbot merge |
Collaborator
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
awgu
pushed a commit
to awgu/pytorch
that referenced
this pull request
Jan 16, 2023
ghstack-source-id: c4a2c36 Pull Request resolved: pytorch#92031
This was referenced Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
r's current device iscuda:r#92035 [FSDP][RFC] Enforce rankr's current device iscuda:ruse_orig_params=True#91767 [FSDP] Do not clean FQNs even foruse_orig_params=Truedevice_id+ CPU offload test #92031 [FSDP][BE] Improvedevice_id+ CPU offload testprefixed_param_names->fqnsfor consolidation #92028 [FSDP][BE] Renameprefixed_param_names->fqnsfor consolidationCloses #83054. The new version of the test ensures that the parent FSDP instance has managed parameters to trigger the
module.to(device_from_device_id)call, which moves the child FSDP instance's managed parameters (and hence must be hackily moved back).