Skip to content

[FSDP][BE] Rename prefixed_param_names -> fqns for consolidation #92028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
awgu wants to merge 5 commits into from
Closed

[FSDP][BE] Rename prefixed_param_names -> fqns for consolidation #92028

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f3d149c
[FSDP][BE] Rename `prefixed_param_names` -> `fqns` for consolidation
Jan 11, 2023
f79178b
Update on "[FSDP][BE] Rename `prefixed_param_names` -> `fqns` for con…
Jan 11, 2023
c8f44a3
Update on "[FSDP][BE] Rename `prefixed_param_names` -> `fqns` for con…
Jan 12, 2023
dfda961
Update on "[FSDP][BE] Rename `prefixed_param_names` -> `fqns` for con…
Jan 12, 2023
8ca5867
Update on "[FSDP][BE] Rename `prefixed_param_names` -> `fqns` for con…
Jan 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 11 additions & 12 deletions torch/distributed/fsdp/_exec_order_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -333,35 +333,34 @@ def _get_names_from_handle_indices(
handle_indices: Tuple[int, ...],
) -> List[List[str]]:
"""
Returns a list of prefixed parameter names for each handle in
``handle_indices``. If a handle index is invalid, then its prefixed
parameter names are omitted from the returned list.
Returns a list of FQNs for each handle in ``handle_indices``. If a
handle index is invalid, then its FQNs are omitted from the returned
list.
"""
prefixed_param_names: List[List[str]] = []
fqns: List[List[str]] = []
for index in handle_indices:
if index is None or index < 0 or index >= len(self.all_handles):
continue
handle = self.all_handles[index]
flat_param = handle.flat_param
prefixed_param_names.append(self.param_to_fqn[flat_param])
return prefixed_param_names
fqns.append(self.param_to_fqn[flat_param])
return fqns

def _get_names_from_handles(
self,
handles_key: _HandlesKey,
) -> List[List[str]]:
"""
Returns a list of prefixed parameter names for each handle in
``handles_key``. If a handle is invalid, then its prefixed parameter
names are omitted from the returned list.
Returns a list of FQNs for each handle in ``handles_key``. If a handle
is invalid, then its FQNs are omitted from the returned list.
"""
prefixed_param_names: List[List[str]] = []
fqns: List[List[str]] = []
for handle in handles_key:
flat_param = handle.flat_param
if flat_param not in self.param_to_fqn:
continue
prefixed_param_names.append(self.param_to_fqn[flat_param])
return prefixed_param_names
fqns.append(self.param_to_fqn[flat_param])
return fqns

def next_iter(self):
"""
Expand Down