[FSDP][BE] Better error msg for incorrect device for training #92027
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ghstack-poisoned]
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/92027
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit a5c32f5: This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
the
release notes: distributed (fsdp)
This was referenced Jan 11, 2023
awgu
commented
Jan 11, 2023
| cpu_device = torch.device("cpu") | ||
| if self._offload_params: | ||
| p_assert( | ||
| flat_param.device == cpu_device, |
Collaborator
Author
There was a problem hiding this comment.
We simplify this assert message because it is an internal assert. Accidentally moving the model to GPU after FSDP constructor will be caught before in _check_flat_params_on_expected_device().
This was referenced Jan 11, 2023
…ing" [ghstack-poisoned]
awgu
requested review from
H-Huang,
kwen2501,
mrshenli,
rohan-varma,
wanchaol and
zhaojuanmao
as code owners
zhaojuanmao
approved these changes
Jan 12, 2023
…ing" Closes #90541. [ghstack-poisoned]
…ing" Closes #90541. [ghstack-poisoned]
…ing" Closes #90541. [ghstack-poisoned]
awgu
pushed a commit
to awgu/pytorch
that referenced
this pull request
Jan 16, 2023
ghstack-source-id: 021adfd Pull Request resolved: pytorch#92027
This was referenced Jan 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack:
r's current device iscuda:r#92035 [FSDP][RFC] Enforce rankr's current device iscuda:ruse_orig_params=True#91767 [FSDP] Do not clean FQNs even foruse_orig_params=Truedevice_id+ CPU offload test #92031 [FSDP][BE] Improvedevice_id+ CPU offload testprefixed_param_names->fqnsfor consolidation #92028 [FSDP][BE] Renameprefixed_param_names->fqnsfor consolidationCloses #90541.